Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

It'd be nice to have the ability to customize the base class so that it can inherit our own class #159

Closed
joelzwarrington opened this issue Apr 2, 2024 · 2 comments · Fixed by #160

Comments

@joelzwarrington
Copy link
Contributor

joelzwarrington commented Apr 2, 2024

It'd be nice if ViewComponent::Form::BaseComponent could be configured so that we can define our own parent class, instead of inheriting from ViewComponent::Base.

@joelzwarrington
Copy link
Contributor Author

Is this something you'd be open to if I worked on it?

I was thinking something similar to Devise' parent_controller configuration where it'd be defined as a string in configuration via initializer and then used like this.

@Spone
Copy link
Collaborator

Spone commented Apr 4, 2024

Hi @joelzwarrington thanks for opening an issue for this. We discussed related topics in #69 and #80. We're totally open to a PR for this!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants