Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

--stop-on-failure does not work with WrapperRunner #262

Closed
willemstuursma opened this issue Jul 5, 2017 · 1 comment · Fixed by #512
Closed

--stop-on-failure does not work with WrapperRunner #262

willemstuursma opened this issue Jul 5, 2017 · 1 comment · Fixed by #512
Labels

Comments

@willemstuursma
Copy link

--stop-on-failure doesn't do anything when running with WrapperRunner.

Here is some output from our CI environment:

TEST_DATABASE=xxxxxx_test_ php -dxdebug.profiler_enable=0 -dxdebug.cli_color=1 -dxdebug.coverage_enable=0 -ddisplay_errors=stderr vendor/bin/paratest --colors --runner WrapperRunner --processes 8 --stop-on-failure --configuration tests/phpunit.xml
Running phpunit in 8 processes with /opt/atlassian/pipelines/agent/build/vendor/bin/phpunit
Configuration read from ./tests/phpunit.xml
.............................................................   61 / 4812 (  1%)
.............................................................  122 / 4822 (  2%)
...............F.............................................  183 / 4828 (  3%)
.............................................................  244 / 4828 (  5%)
.............................................................  305 / 4832 (  6%)
.............................................................  366 / 4847 (  7%)
.............................................................  427 / 4857 (  8%)
.............................................................  488 / 4865 ( 10%)
.............................................................  549 / 4866 ( 11%)

As you can see, it dutifully labours on even after the failure.

@rask
Copy link

rask commented May 27, 2019

Seeing the same issue here. I even passthru --stop-on-error --stop-on-defect --stop-on-failure to PHPUnit but that makes no difference.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants