Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SIMD removal from rust #3269

Closed
2 tasks done
driemworks opened this issue Feb 8, 2024 · 3 comments · Fixed by #3296
Closed
2 tasks done

SIMD removal from rust #3269

driemworks opened this issue Feb 8, 2024 · 3 comments · Fixed by #3296
Labels
I2-bug The node fails to follow expected behavior.

Comments

@driemworks
Copy link

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

SIMD was removed from the latest rust nightly version rust-lang/rust#117372 which causes ahash 0.7.7 to break: tkaitchuck/aHash#200. This has been resolved in versions >= 0.8.X tkaitchuck/aHash#183.

error[E0635]: unknown feature `stdsimd`
  --> /home/XXXX/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.7.7/src/lib.rs:33:42
   |
33 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
   |                                          ^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `ahash` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Steps to reproduce

  1. Clone the polkadot-sdk master branch
  2. Update to the latest rust nightly version (as of this comment: nightly-x86_64-unknown-linux-gnu - rustc 1.78.0-nightly (8ace7ea1f 2024-02-07))
  3. Build the project
git clone https://github.com/paritytech/polkadot-sdk.git
rustup update nightly
cargo +nightly build --release
@driemworks driemworks added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Feb 8, 2024
@ggwpez
Copy link
Member

ggwpez commented Feb 8, 2024

Hm, we can update criterion which seems to pull it in a lot and maybe some other deps.
Note that we normally use stable and not nightly to build, but its indeed a bummer.

PS: Updating criterion errors with this: rust-bitcoin/rust-bip39#64

@ggwpez ggwpez removed the I10-unconfirmed Issue might be valid, but it's not yet known. label Feb 8, 2024
@ggwpez
Copy link
Member

ggwpez commented Feb 12, 2024

Other ideas @bkchr ?

@burdges
Copy link

burdges commented Feb 12, 2024

github-merge-queue bot pushed a commit that referenced this issue Feb 13, 2024
We need to bump `ahash` to make it compile again.

Closes: #3269
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
We need to bump `ahash` to make it compile again.

Closes: paritytech#3269
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
I2-bug The node fails to follow expected behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants