Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Adds state_queryStorageAt #5362

Merged
merged 4 commits into from
Mar 26, 2020
Merged

Adds state_queryStorageAt #5362

merged 4 commits into from
Mar 26, 2020

Conversation

seunlanlege
Copy link
Contributor

see #5220

@seunlanlege seunlanlege requested a review from tomusdrw as a code owner March 23, 2020 15:38
@parity-cla-bot
Copy link

It looks like @seunlanlege signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@seunlanlege seunlanlege added A0-please_review Pull request needs code review. B1-clientnoteworthy labels Mar 23, 2020
@seunlanlege seunlanlege added this to the Polkadot milestone Mar 23, 2020
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Minor grumbles.

seunlanlege and others added 2 commits March 26, 2020 10:52
Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
@bkchr
Copy link
Member

bkchr commented Mar 26, 2020

Can you please add a test? #5362 (comment)

Comment on lines +241 to +247
if has_changes_trie_config {
assert_eq!(
client.max_key_changes_range(1, BlockId::Hash(block1_hash)).unwrap(),
Some((0, BlockId::Hash(block1_hash))),
);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkchr already added.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh nice! Ty!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants