Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Alter SignedExtension and related to cater for more advanced exts like SkipCheckIfFeeless #1280

Closed
jsdw opened this issue Nov 21, 2023 · 0 comments · Fixed by #1283
Closed
Assignees

Comments

@jsdw
Copy link
Collaborator

jsdw commented Nov 21, 2023

SkipCheckIfFeeless is a signed ext that wraps another, but externally just has the name SkipCheckIfFeeless.

The current impl of it on master will return an error if the ext is not present on a chain, rather than being able to be silently ignored if not needed. But more than that, matching on just the name of the signed ext is bound to lead to future issues with this sort of ext in existence (if a chain has two exts wrapped in SkipCheckIfFeeless, we won't be able to match things up properly any more).

So, the goal here will be to modify the related traits so that signed extensions can search for themselves more intelligently, and also have the ability to return errors at the point of encoding (because they become more possible.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant