-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
config: Add SkipCheckIfFeeless
signed extension
#1264
Merged
Merged
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1f29b70
config: Add `SkipCheckIfFeeless` signed extension
lexnv 82d4565
config: Add extra extension to the default params
lexnv e0a01ea
examples: Adjust signed extension example
lexnv 3bee7b3
config: Extend SkipCheckIfFeeless with inner signed extension
lexnv 678beaf
config: Configure SkipCheck with inner signed extension params
lexnv a458281
config: Implement Deafult for SkipCheckIfFeelessParams with Option
lexnv d3e41f7
examples: Fix example with proper extension
lexnv 2f496ac
config: Extend <T as Config>::AssetId with EncodeAsType and Clone
lexnv ce731a3
config: Add SkipCheck with AssetTx
lexnv 39c11c7
config: Encode as type from metadata the inner signed extensions
lexnv 9ca8ee1
Adjust examples
lexnv eef166d
blocks: Use `SkipCheckIfFeeless` for decoding the tip of extensions
lexnv 094298b
config: Decode `SkipCheckIfFeeless` with `Self`
lexnv 57f771d
tests: Adjust testing
lexnv 3cb3793
config: Descriptive errors for building `SkipCheckIfFeeless`
lexnv 1666adc
config: Add docs for extra error types
lexnv 8eabd0f
subxt: Add extra derives to signed extensions
lexnv a4c8e5a
config: Use `Default::default` to simplify type init
lexnv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it didn't work to derive clone for all types instead? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope :( I've raised #1268 to track this in the future.
subxt/subxt/src/lib.rs
Lines 231 to 235 in eeacf4b