Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bugfix: trimmed metadata hash comparison fails in is_codegen_valid_for #1301

Closed
wants to merge 4 commits into from
Closed

Bugfix: trimmed metadata hash comparison fails in is_codegen_valid_for #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6f97dc
Fix bug about trimmed metadata
tadeohepperle Dec 1, 2023
19207cf
add test to validate it
tadeohepperle Dec 1, 2023
43cdde5
formatting
tadeohepperle Dec 1, 2023
bd6ce98
broken commit with new type hash ordering approach, will continue nex…
tadeohepperle Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions metadata/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ impl<'a> PalletMetadata<'a> {

/// Return a hash for the entire pallet.
pub fn hash(&self) -> [u8; HASH_LEN] {
crate::utils::validation::get_pallet_hash(*self)
crate::utils::validation::get_pallet_hash(*self, None)
}
}

Expand Down Expand Up @@ -643,7 +643,7 @@ impl<'a> RuntimeApiMetadata<'a> {

/// Return a hash for the runtime API trait.
pub fn hash(&self) -> [u8; HASH_LEN] {
crate::utils::validation::get_runtime_trait_hash(*self)
crate::utils::validation::get_runtime_trait_hash(*self, None)
}
}

Expand Down
Loading