Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unit test for the branch decoder #17

Open
branylagaffe opened this issue Aug 7, 2024 · 5 comments
Open

Unit test for the branch decoder #17

branylagaffe opened this issue Aug 7, 2024 · 5 comments
Assignees

Comments

@branylagaffe
Copy link
Contributor

branylagaffe commented Aug 7, 2024

I want to test for the branch decoder
So that @giorgioajmone can rely on the decoder to work on a BP

Specification:

  1. There shall be unit tests testing the branch decoder for each type of branch instruction. These are:
    • unconditional branch (immediate)
    • unconditional branch (register)
    • conditional branch
    • compare and branch
    • test and branch
  2. There should? be unit tests for these other instruction types that are under the same "Branches, Exception Generating and System instructions" section in the ARM manual:
    • exception generation? (supervisor call, hypervisor call, etc.)
    • hints? (includes things like the pointer authentication instruction AUTIASP which is apparently used by the stress snapshot as pointed out by @BugraEryilmaz)
    • barriers? (we already have a branch_type_t enum value called QEMU_Barrier_Branch in libqflex-legacy-api.h but it is actually never used by the current branch decoder)
    • ...?

Tasks:

  1. Figure what needs to be tested/ what is handled by KeenKraken
  2. Write specification
@branylagaffe
Copy link
Contributor Author

@ounuvar Please fill the [] in the description.

@branylagaffe branylagaffe changed the title test for the branch decoder Unit test for the branch decoder Aug 7, 2024
@ounuvar
Copy link
Collaborator

ounuvar commented Aug 7, 2024

Should I push the current branch tests (which cover everything under Specification-1.) to the same testing branch where the load-store tests were? @branylagaffe

@branylagaffe
Copy link
Contributor Author

Yeah thats okay

@branylagaffe
Copy link
Contributor Author

or you can create a new branch starting form the previous testing branch, maybe with a name such as `test/decoder

@ounuvar
Copy link
Collaborator

ounuvar commented Aug 7, 2024

Pushed them to the same testing branch

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants