Skip to content

Commit 3bf9047

Browse files
yulingtianxiaphillwiggins
authored andcommitted
Hot-fix (#209)
* Merged v1.0.22 * 1. Fix return result from save method. This is important. 2. Fix unsavedChanges issue in ParseUser login and # method. 3. Delete useless and reduplicative decode in ParseUser. Because this is already done in handleResponse method. This also cause wrong unsaved changes.
1 parent ea77ae6 commit 3bf9047

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

lib/src/objects/parse_object.dart

+1
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ class ParseObject extends ParseBase implements ParseCloneable {
108108
else {
109109
_revertSavingChanges();
110110
}
111+
return response;
111112
}
112113
}
113114
return childrenResponse;

lib/src/objects/parse_user.dart

+4-3
Original file line numberDiff line numberDiff line change
@@ -136,11 +136,13 @@ class ParseUser extends ParseObject implements ParseCloneable {
136136
bodyData[keyVarPassword] = password;
137137
bodyData[keyVarUsername] = username;
138138
final Uri url = getSanitisedUri(_client, '$path');
139+
final String body = json.encode(bodyData);
140+
_saveChanges();
139141
final Response response = await _client.post(url,
140142
headers: <String, String>{
141143
keyHeaderRevocableSession: '1',
142144
},
143-
body: json.encode(bodyData));
145+
body: body);
144146

145147
return _handleResponse(
146148
this, response, ParseApiRQ.#, _debug, parseClassName);
@@ -162,7 +164,7 @@ class ParseUser extends ParseObject implements ParseCloneable {
162164

163165
final Uri url = getSanitisedUri(_client, '$keyEndPointLogin',
164166
queryParams: queryParams);
165-
167+
_saveChanges();
166168
final Response response =
167169
await _client.get(url, headers: <String, String>{
168170
keyHeaderRevocableSession: '1',
@@ -356,7 +358,6 @@ class ParseUser extends ParseObject implements ParseCloneable {
356358

357359
final Map<String, dynamic> responseData = jsonDecode(response.body);
358360
if (responseData.containsKey(keyVarObjectId)) {
359-
parseResponse.result.fromJson(responseData);
360361
user.sessionToken = responseData[keyParamSessionToken];
361362
ParseCoreData().setSessionId(user.sessionToken);
362363
}

0 commit comments

Comments
 (0)