Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Add and, nor operators in QueryBuilder #795

Merged
merged 10 commits into from
Dec 21, 2022
Merged

feat: Add and, nor operators in QueryBuilder #795

merged 10 commits into from
Dec 21, 2022

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Oct 18, 2022 •
edited
Loading

New Pull Request Checklist

Issue Description

add and and nor
add _constructorInitializer function for handle and , nor and or in QueryBuilder
add three tests for and, nor, or
Related issue: #796

Approach

The value of and and nor was not present in this package

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

@mbfakourii
add "and" and "nor" in QueryBuilder
da5dcd1 
add "and" and "nor" 
add ```_constructorInitialize``` function for handle "and" , "nor" and "or" in QueryBuilder
@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 18, 2022 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mbfakourii
add "and" and "nor" in QueryBuilder
804525c 
add "and" and "nor" 
add ```_constructorInitialize``` function for handle "and" , "nor" and "or" in QueryBuilder
@mtrezza mtrezza changed the title add "and" and "nor" in QueryBuilder feat: add and, nor operators in QueryBuilder Oct 19, 2022
mtrezza
mtrezza requested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests? There is also a lint issue.

@codecov
Copy link

codecov bot commented Oct 19, 2022 •
edited
Loading

Codecov Report

Base: 10.56% // Head: 11.52% // Increases project coverage by +0.96% 🎉

Coverage data is based on head (92c9ef4) compared to base (26b8698).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
+ Coverage   10.56%   11.52%   +0.96%     
==========================================
  Files          47       47              
  Lines        2840     2846       +6     
==========================================
+ Hits          300      328      +28     
+ Misses       2540     2518      -22
Impacted Files Coverage Δ
packages/dart/lib/src/network/parse_query.dart 20.31% <100.00%> (+10.11%) ⬆️
packages/dart/lib/src/utils/parse_utils.dart 41.17% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mbfakourii
Copy link
Member Author

mbfakourii commented Oct 27, 2022 •
edited
Loading

Could you add tests? There is also a lint issue.

added three tests for and, nor, or

and need added to README.md?

@mtrezza
Copy link
Member

mtrezza commented Oct 27, 2022

I don't think you need to add anything to README, what would you add?

@mbfakourii
Copy link
Member Author

mbfakourii commented Oct 28, 2022 •
edited
Loading

I don't think you need to add anything to README, what would you add?

documentation for how to use and and nor

@mtrezza
Copy link
Member

mtrezza commented Oct 29, 2022

Oh, if that's not there yet, it would be great if you could add it!

@mbfakourii
Copy link
Member Author

README.md updated

@mtrezza mtrezza requested a review from a team October 29, 2022 17:54
mtrezza
mtrezza reviewed Nov 13, 2022
View reviewed changes
mtrezza
mtrezza reviewed Nov 13, 2022
View reviewed changes
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: add and, nor operators in QueryBuilder feat: Add and, nor operators in QueryBuilder Nov 13, 2022
@mbfakourii
Copy link
Member Author

mbfakourii commented Dec 19, 2022 •
edited
Loading

@mtrezza
I use and in a project that is used by several people every day. It seems that there is no problem

@mtrezza
Copy link
Member

mtrezza commented Dec 21, 2022

Rerunning failed tests

@mbfakourii
Copy link
Member Author

Rerunning failed tests

What is the problem, like all the tests are passed

@mtrezza
Copy link
Member

mtrezza commented Dec 21, 2022 •
edited
Loading

Now they do, earlier they did not, probably some flaky tests.
Could you again bump the versions and add the changelog entry?

@mbfakourii
Copy link
Member Author

Now they do, earlier they did not, probably some flaky tests. Could you again bump the versions and add the changelog entry?

Changes were added

mtrezza
mtrezza reviewed Dec 21, 2022
View reviewed changes
mtrezza
mtrezza previously approved these changes Dec 21, 2022
View reviewed changes
@mtrezza mtrezza merged commit 2befe18 into parse-community:master Dec 21, 2022
@mbfakourii mbfakourii deleted the patch-3 branch December 21, 2022 15:21
@mbfakourii mbfakourii restored the patch-3 branch December 21, 2022 15:21
@mbfakourii mbfakourii mentioned this pull request Dec 23, 2022
Closed
3 tasks
@mbfakourii mbfakourii deleted the patch-3 branch May 23, 2023 11:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mtrezza mtrezza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbfakourii @mtrezza