-
-
Notifications
You must be signed in to change notification settings - Fork 206
feat: Add include
option to getObject
and fetch
#798
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Add include
option to getObject
and fetch
#798
Conversation
Thanks for opening this pull request!
|
Codecov ReportBase: 11.52% // Head: 13.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
==========================================
+ Coverage 11.52% 13.66% +2.13%
==========================================
Files 47 47
Lines 2846 2847 +1
==========================================
+ Hits 328 389 +61
+ Misses 2518 2458 -60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
(Sorry for tagging everyone for review here; but we didn't get any reviews on the last PR, so I hope someone could talk a look at this) |
include
option to getObject
and fetch
Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you bump the version and add the cangelog?
added |
Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com>
New Pull Request Checklist
Issue Description
Added
include
ingetObject
andfetch
Added test
Related issue: #797
Approach
In
ParseObject
class andgetObject
andfetch
functions there is no valueinclude
TODOs before merging