adding or removing values from or into an array and then calling `get` returns `_Map<String, dynamic>` #834

Nidal-Bakir · 2023-03-01T09:02:17Z

New Issue Checklist

I am not disclosing a vulnerability.
I am not just asking a question.
I have searched through existing issues.
I can reproduce the issue with the latest version of Parse Server and the Parse Flutter SDK.

Issue Description

Adding or removing values from or into an array using (setAdd, setAddAll, setAddUnique, setAddAllUnique, setRemove, setRemoveAll) in ParseObject and then calling get returns _Map<String, dynamic>

related to: #696, #842

Steps to reproduce

create ParseObject
add a value to an array using setAdd function for example
get the array using the array key with get("key")
the result of calling get("key") is Map which is not expected

code snippet:

final dietPlansObject = ParseObject("Diet_Plans");

dietPlansObject.setAdd("arrayKey", 1);

final array = dietPlansObject.get("arrayKey");

print(array.runtimeType); // _Map<String, dynamic>

Actual Outcome

_Map<String, dynamic>

Expected Outcome

An Iterable that contains all the added values and does not contain the removed ones

Environment

Parse Flutter SDK

SDK version: 3.1.15
Operating system version: any

Server

Parse Server version: any

Logs

type '_Map<String, dynamic>' is not a subtype of type 'List?' in type cast
package:parse_server_sdk/src/objects/parse_base.dart 223:36 ParseBase.get
test/src/objects/parse_object_test.dart 711:39 main...
parse_object_test.dart:711

The text was updated successfully, but these errors were encountered:

parse-github-assistant · 2023-03-01T09:02:19Z

Thanks for opening this issue!

🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

Nidal-Bakir · 2023-03-01T09:05:50Z

I just find it out while writing tests for ParseObject class.

I have written all the tests to make sure that will not happen again. we just need to fix it. I will open a new PR to attempt to fix this after this PR #805 is merged.

Tests

group('Array', () {
    const keyArray = 'array';

    late ParseObject dietPlansObject;

    setUp(() {
      dietPlansObject = ParseObject("Diet_Plans", client: client);
    });

    test(
        'adding values using setAdd() and then calling get(keyArray) '
        'should return Instance of Iterable that contains all the added values ',
        () {
      // act
      dietPlansObject.setAdd(keyArray, 1);
      dietPlansObject.setAdd(keyArray, 2);
      dietPlansObject.setAdd(keyArray, 1);

      // assert
      final array = dietPlansObject.get(keyArray);

      expect(array, isA<Iterable>());

      expect(
        DeepCollectionEquality.unordered().equals(
          array,
          [1, 2, 1],
        ),
        isTrue,
      );
    });

    test(
        'adding values using setAddAll() and then calling get(keyArray) '
        'should return Instance of Iterable that contains all the added values',
        () {
      // act
      dietPlansObject.setAddAll(keyArray, [1, 2, 1]);

      // assert
      final array = dietPlansObject.get(keyArray);

      expect(array, isA<Iterable>());

      expect(
        DeepCollectionEquality.unordered().equals(
          array,
          [1, 2, 1],
        ),
        isTrue,
      );
    });

    test(
        'adding values using setAddUnique() and then calling get(keyArray) '
        'should return Instance of Iterable that contains all the added values'
        ' with out any duplication in the values', () {
      // act
      dietPlansObject.setAddUnique(keyArray, 1);
      dietPlansObject.setAddUnique(keyArray, 2);
      dietPlansObject.setAddUnique(keyArray, 1);
      dietPlansObject.setAddUnique(keyArray, 3);
      dietPlansObject.setAddUnique(keyArray, 1);
      dietPlansObject.setAddUnique(keyArray, 4);

      // assert
      final array = dietPlansObject.get(keyArray);

      expect(array, isA<Iterable>());

      expect(
        DeepCollectionEquality.unordered().equals(
          array,
          [1, 2, 3, 4],
        ),
        isTrue,
      );
    });

    test(
        'adding values using setAddAllUnique() and then calling get(keyArray) '
        'should return Instance of Iterable that contains all the added values'
        ' with out any duplication in the values', () {
      // act
      dietPlansObject.setAddAllUnique(keyArray, [1, 2, 1, 3, 1, 4, 1]);

      // assert
      final array = dietPlansObject.get(keyArray);

      expect(array, isA<Iterable>());

      expect(
        DeepCollectionEquality.unordered().equals(
          array,
          [1, 2, 3, 4],
        ),
        isTrue,
      );
    });

    test(
        'removing values using setRemove() and then calling get(keyArray) '
        'should return Instance of Iterable that NOT contains the removed values',
        () {
      // arrange
      final resultFromServer = {
        "objectId": "O6BHlwV48Z",
        "createdAt": "2023-02-26T13:23:03.073Z",
        "updatedAt": "2023-03-01T03:38:16.390Z",
        keyArray: [1, 2, 3, 4],
      };

      dietPlansObject = ParseObject('Diet_Plans')
        ..fromJson(
          resultFromServer,
        );

      // act
      dietPlansObject.setRemove(keyArray, 4);

      // assert
      final array = dietPlansObject.get(keyArray);

      expect(array, isA<Iterable>());

      expect(
        DeepCollectionEquality.unordered().equals(
          array,
          [1, 2, 3],
        ),
        isTrue,
      );
    });

    test(
        'removing values using setRemoveAll() and then calling get(keyArray) '
        'should return Instance of Iterable that NOT contains the removed values',
        () {
      // arrange
      final resultFromServer = {
        "objectId": "O6BHlwV48Z",
        "createdAt": "2023-02-26T13:23:03.073Z",
        "updatedAt": "2023-03-01T03:38:16.390Z",
        keyArray: [1, 2, 3, 4],
      };

      dietPlansObject = ParseObject('Diet_Plans')
        ..fromJson(
          resultFromServer,
        );

      // act
      dietPlansObject.setRemoveAll(keyArray, [3, 4]);

      // assert
      final array = dietPlansObject.get(keyArray);

      expect(array, isA<Iterable>());

      expect(
        DeepCollectionEquality.unordered().equals(
          array,
          [1, 2],
        ),
        isTrue,
      );
    });

    test(
        'the array should not been affected by removing non existent '
        'values using setRemove()', () {
      // arrange
      final resultFromServer = {
        "objectId": "O6BHlwV48Z",
        "createdAt": "2023-02-26T13:23:03.073Z",
        "updatedAt": "2023-03-01T03:38:16.390Z",
        keyArray: [1, 2, 3, 4],
      };

      dietPlansObject = ParseObject('Diet_Plans')
        ..fromJson(
          resultFromServer,
        );

      // act
      dietPlansObject.setRemove(keyArray, 15);
      dietPlansObject.setRemove(keyArray, 16);

      // assert
      final array = dietPlansObject.get(keyArray);

      expect(array, isA<Iterable>());

      expect(
        DeepCollectionEquality.unordered().equals(
          array,
          [1, 2, 3, 4],
        ),
        isTrue,
      );
    });

    test(
        'the array should not been affected by removing non existent '
        'values using setRemoveAll()', () {
      // arrange
      final resultFromServer = {
        "objectId": "O6BHlwV48Z",
        "createdAt": "2023-02-26T13:23:03.073Z",
        "updatedAt": "2023-03-01T03:38:16.390Z",
        keyArray: [1, 2, 3, 4],
      };

      dietPlansObject = ParseObject('Diet_Plans')
        ..fromJson(
          resultFromServer,
        );

      // act
      dietPlansObject.setRemoveAll(keyArray, [15, 16]);

      // assert
      final array = dietPlansObject.get(keyArray);

      expect(array, isA<Iterable>());

      expect(
        DeepCollectionEquality.unordered().equals(
          array,
          [1, 2, 3, 4],
        ),
        isTrue,
      );
    });

    test(
        'adding to an array and then removing from it should result in error '
        'the user can not add and remove in the same time', () {
      // act
      dietPlansObject.setAdd(keyArray, 1);
      dietPlansObject.setAdd(keyArray, 2);

      // assert
      expect(
        () => dietPlansObject.setRemove(keyArray, 2),
        throwsA(isA<String>()),
      );

      final array = dietPlansObject.get(keyArray);

      expect(array, isA<Iterable>());

      expect(
        DeepCollectionEquality.unordered().equals(
          array,
          [1, 2],
        ),
        isTrue,
      );
    });

    test(
        'removing from an array and then adding to it should result in error '
        'the user can not remove and add in the same time', () {
      // arrange
      final resultFromServer = {
        "objectId": "O6BHlwV48Z",
        "createdAt": "2023-02-26T13:23:03.073Z",
        "updatedAt": "2023-03-01T03:38:16.390Z",
        keyArray: [1, 2, 3, 4],
      };

      dietPlansObject = ParseObject('Diet_Plans')
        ..fromJson(
          resultFromServer,
        );

      // act
      dietPlansObject.setRemove(keyArray, 4);
      dietPlansObject.setRemove(keyArray, 3);

      // assert
      expect(
        () => dietPlansObject.setAdd(keyArray, 5),
        throwsA(isA<String>()),
      );

      final array = dietPlansObject.get(keyArray);

      expect(array, isA<Iterable>());

      expect(
        DeepCollectionEquality.unordered().equals(
          array,
          [1, 2],
        ),
        isTrue,
      );
    });
  });

mtrezza · 2023-03-01T14:22:57Z

Thanks @Nidal-Bakir; you've been quite active recently, would you be interested in joining the Parse Flutter SDK review team? You'll get notified when there's a review request for PRs.

Nidal-Bakir · 2023-03-02T05:50:18Z

Thank you for the offer, @mtrezza I would be honored to join the Parse Flutter SDK review team and contribute to the development of the SDK.

mtrezza · 2023-03-02T06:16:16Z

Great, you'll receive an invitation shortly

Nidal-Bakir · 2023-05-13T22:01:05Z

Fix via #860

mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Mar 1, 2023

Nidal-Bakir mentioned this issue Mar 4, 2023

Incrementing or Decrementing a value and then calling get returns _Map<String, dynamic> #842

Closed

4 tasks

Nidal-Bakir self-assigned this Mar 11, 2023

mtrezza unassigned Nidal-Bakir Mar 12, 2023

Nidal-Bakir mentioned this issue Mar 19, 2023

fix: Setting atomic operation on Parse Object returns operation instead of prospective value #860

Merged

5 tasks

Nidal-Bakir closed this as completed May 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding or removing values from or into an array and then calling `get` returns `_Map<String, dynamic>` #834

adding or removing values from or into an array and then calling `get` returns `_Map<String, dynamic>` #834

Nidal-Bakir commented Mar 1, 2023 •

edited

Loading

parse-github-assistant bot commented Mar 1, 2023 •

edited

Loading

Nidal-Bakir commented Mar 1, 2023 •

edited

Loading

mtrezza commented Mar 1, 2023

Nidal-Bakir commented Mar 2, 2023

mtrezza commented Mar 2, 2023

Nidal-Bakir commented May 13, 2023

adding or removing values from or into an array and then calling get returns _Map<String, dynamic> #834

adding or removing values from or into an array and then calling get returns _Map<String, dynamic> #834

Comments

Nidal-Bakir commented Mar 1, 2023 • edited Loading

New Issue Checklist

Issue Description

Steps to reproduce

Actual Outcome

Expected Outcome

Environment

Logs

parse-github-assistant bot commented Mar 1, 2023 • edited Loading

Thanks for opening this issue!

Nidal-Bakir commented Mar 1, 2023 • edited Loading

mtrezza commented Mar 1, 2023

Nidal-Bakir commented Mar 2, 2023

mtrezza commented Mar 2, 2023

Nidal-Bakir commented May 13, 2023

adding or removing values from or into an array and then calling `get` returns `_Map<String, dynamic>` #834

adding or removing values from or into an array and then calling `get` returns `_Map<String, dynamic>` #834

Nidal-Bakir commented Mar 1, 2023 •

edited

Loading

parse-github-assistant bot commented Mar 1, 2023 •

edited

Loading

Nidal-Bakir commented Mar 1, 2023 •

edited

Loading