fix: LiveQuery server is not shut down properly when `handleShutdown` is called #8491

dblythy · 2023-03-30T06:12:18Z

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

When using startLiveQueryServer, the LQ server isn't shutdown after tests. This can be verified with:

const server = await reconfigureServer({
      liveQuery: {
        classNames: ['TestObject'],
      },
      startLiveQueryServer: true,
    });
await server.handleShutdown();
await new Promise(resolve => setTimeout(resolve, 100));
expect(server.liveQueryServer.server.address()).toBeNull(); // liveQuery server has an address

Closes: #8424

Approach

Closes LQ Server at handleShutdown

Tasks

Add tests

…-community#7839)

## [5.2.1-alpha.1](parse-community/parse-server@5.2.0...5.2.1-alpha.1) (2022-03-26) ### Bug Fixes * return correct response when revert is used in beforeSave ([parse-community#7839](parse-community#7839)) ([f63fb2b](parse-community@f63fb2b))

… Cloud Function validation (parse-community#7892)

## [5.2.1-alpha.2](parse-community/parse-server@5.2.1-alpha.1...5.2.1-alpha.2) (2022-03-26) ### Performance Improvements * reduce database operations when using the constant parameter in Cloud Function validation ([parse-community#7892](parse-community#7892)) ([48bd512](parse-community@48bd512))

# [5.3.0-alpha.1](parse-community/parse-server@5.2.1-alpha.2...5.3.0-alpha.1) (2022-03-27) ### Features * add MongoDB 5.1 compatibility ([parse-community#7682](parse-community#7682)) ([90155cf](parse-community@90155cf))

…ommunity#7893)

# [5.3.0-alpha.2](parse-community/parse-server@5.3.0-alpha.1...5.3.0-alpha.2) (2022-03-27) ### Bug Fixes * security upgrade parse push adapter from 4.1.0 to 4.1.2 ([parse-community#7893](parse-community#7893)) ([ef56e98](parse-community@ef56e98))

# [5.3.0-alpha.3](parse-community/parse-server@5.3.0-alpha.2...5.3.0-alpha.3) (2022-03-27) ### Features * add MongoDB 5.2 support ([parse-community#7894](parse-community#7894)) ([6b4b358](parse-community@6b4b358))

…alpha

parse-github-assistant · 2023-03-30T06:12:20Z

I will reformat the title to use the proper commit message syntax.

parse-github-assistant · 2023-03-30T06:12:23Z

Thanks for opening this pull request!

codecov · 2023-03-30T06:22:42Z

Codecov Report

Patch coverage: 92.85% and project coverage change: +0.10 🎉

Comparison is base (656d673) 94.32% compared to head (5ce1f17) 94.43%.

❗ Current head 5ce1f17 differs from pull request most recent head 91c0bdb. Consider uploading reports for the commit 91c0bdb to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha    #8491      +/-   ##
==========================================
+ Coverage   94.32%   94.43%   +0.10%     
==========================================
  Files         183      183              
  Lines       14582    14594      +12     
==========================================
+ Hits        13755    13782      +27     
+ Misses        827      812      -15

Impacted Files	Coverage Δ
src/Adapters/Storage/Mongo/MongoStorageAdapter.js	`92.19% <66.66%> (+0.01%)`	⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js	`95.74% <100.00%> (+<0.01%)`	⬆️
src/LiveQuery/ParseLiveQueryServer.js	`96.03% <100.00%> (+0.04%)`	⬆️
src/ParseServer.js	`97.44% <100.00%> (+4.80%)`	⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

dplewis · 2023-04-01T03:47:07Z

Looks good!

src/LiveQuery/ParseLiveQueryServer.js

mtrezza · 2023-04-10T23:32:10Z

Waiting for CI to pass...

For some reason it seems that no runner is picking up ci / Check Definitions (pull_request). Maybe the ubuntu version is too old - could you try to change it from ubuntu-18.04 to ubuntu-latest?

dblythy · 2023-04-11T02:04:54Z

Addressed in #8503

mtrezza · 2023-04-11T17:59:08Z

Rebasing...

mtrezza · 2023-04-11T19:56:18Z

Could you take a look at the failing definitions check?

mtrezza · 2023-04-14T11:52:52Z

Is this ready for merge?

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

mtrezza · 2023-06-08T01:09:26Z

@dblythy is this ready for merge (if CI passes)?

dblythy · 2023-06-08T01:21:52Z

Yep!

# [6.1.0-alpha.19](6.1.0-alpha.18...6.1.0-alpha.19) (2023-06-08) ### Bug Fixes * LiveQuery server is not shut down properly when `handleShutdown` is called ([#8491](#8491)) ([967700b](967700b))

parseplatformorg · 2023-06-08T09:06:09Z

🎉 This change has been released in version 6.1.0-alpha.19

# [6.3.0-beta.1](6.2.0...6.3.0-beta.1) (2023-06-10) ### Bug Fixes * Cloud Code Trigger `afterSave` executes even if not set ([#8520](#8520)) ([afd0515](afd0515)) * GridFS file storage doesn't work with certain `enableSchemaHooks` settings ([#8467](#8467)) ([d4cda4b](d4cda4b)) * Inaccurate table total row count for PostgreSQL ([#8511](#8511)) ([0823a02](0823a02)) * LiveQuery server is not shut down properly when `handleShutdown` is called ([#8491](#8491)) ([967700b](967700b)) * Rate limit feature is incompatible with Node 14 ([#8578](#8578)) ([f911f2c](f911f2c)) * Unnecessary log entries by `extendSessionOnUse` ([#8562](#8562)) ([fd6a007](fd6a007)) ### Features * `extendSessionOnUse` to automatically renew Parse Sessions ([#8505](#8505)) ([6f885d3](6f885d3)) * Add new Parse Server option `prevent#WithUnverifiedEmail` to prevent returning a user without session token on sign-up with unverified email address ([#8451](#8451)) ([82da308](82da308)) * Add option to change the log level of logs emitted by Cloud Functions ([#8530](#8530)) ([2caea31](2caea31)) * Add support for `$eq` query constraint in LiveQuery ([#8614](#8614)) ([656d673](656d673)) * Add zones for rate limiting by `ip`, `user`, `session`, `global` ([#8508](#8508)) ([03fba97](03fba97)) * Allow `Parse.Object` pointers in Cloud Code arguments ([#8490](#8490)) ([28aeda3](28aeda3)) ### Reverts * fix: Inaccurate table total row count for PostgreSQL ([6722110](6722110))

parseplatformorg · 2023-06-10T23:07:15Z

🎉 This change has been released in version 6.3.0-beta.1

# [6.3.0-alpha.1](6.2.0...6.3.0-alpha.1) (2023-06-18) ### Bug Fixes * Cloud Code Trigger `afterSave` executes even if not set ([#8520](#8520)) ([afd0515](afd0515)) * GridFS file storage doesn't work with certain `enableSchemaHooks` settings ([#8467](#8467)) ([d4cda4b](d4cda4b)) * Inaccurate table total row count for PostgreSQL ([#8511](#8511)) ([0823a02](0823a02)) * LiveQuery server is not shut down properly when `handleShutdown` is called ([#8491](#8491)) ([967700b](967700b)) * Rate limit feature is incompatible with Node 14 ([#8578](#8578)) ([f911f2c](f911f2c)) * Unnecessary log entries by `extendSessionOnUse` ([#8562](#8562)) ([fd6a007](fd6a007)) ### Features * `extendSessionOnUse` to automatically renew Parse Sessions ([#8505](#8505)) ([6f885d3](6f885d3)) * Add new Parse Server option `prevent#WithUnverifiedEmail` to prevent returning a user without session token on sign-up with unverified email address ([#8451](#8451)) ([82da308](82da308)) * Add option to change the log level of logs emitted by Cloud Functions ([#8530](#8530)) ([2caea31](2caea31)) * Add support for `$eq` query constraint in LiveQuery ([#8614](#8614)) ([656d673](656d673)) * Add zones for rate limiting by `ip`, `user`, `session`, `global` ([#8508](#8508)) ([03fba97](03fba97)) * Allow `Parse.Object` pointers in Cloud Code arguments ([#8490](#8490)) ([28aeda3](28aeda3)) ### Reverts * fix: Inaccurate table total row count for PostgreSQL ([6722110](6722110))

parseplatformorg · 2023-06-18T01:23:16Z

🎉 This change has been released in version 6.3.0-alpha.1

# [6.3.0](6.2.2...6.3.0) (2023-09-16) ### Bug Fixes * Cloud Code Trigger `afterSave` executes even if not set ([#8520](#8520)) ([afd0515](afd0515)) * GridFS file storage doesn't work with certain `enableSchemaHooks` settings ([#8467](#8467)) ([d4cda4b](d4cda4b)) * Inaccurate table total row count for PostgreSQL ([#8511](#8511)) ([0823a02](0823a02)) * LiveQuery server is not shut down properly when `handleShutdown` is called ([#8491](#8491)) ([967700b](967700b)) * Rate limit feature is incompatible with Node 14 ([#8578](#8578)) ([f911f2c](f911f2c)) * Unnecessary log entries by `extendSessionOnUse` ([#8562](#8562)) ([fd6a007](fd6a007)) ### Features * `extendSessionOnUse` to automatically renew Parse Sessions ([#8505](#8505)) ([6f885d3](6f885d3)) * Add new Parse Server option `prevent#WithUnverifiedEmail` to prevent returning a user without session token on sign-up with unverified email address ([#8451](#8451)) ([82da308](82da308)) * Add option to change the log level of logs emitted by Cloud Functions ([#8530](#8530)) ([2caea31](2caea31)) * Add support for `$eq` query constraint in LiveQuery ([#8614](#8614)) ([656d673](656d673)) * Add zones for rate limiting by `ip`, `user`, `session`, `global` ([#8508](#8508)) ([03fba97](03fba97)) * Allow `Parse.Object` pointers in Cloud Code arguments ([#8490](#8490)) ([28aeda3](28aeda3)) ### Reverts * fix: Inaccurate table total row count for PostgreSQL ([6722110](6722110))

parseplatformorg · 2023-09-16T01:11:24Z

🎉 This change has been released in version 6.3.0

mtrezza and others added 23 commits March 25, 2022 19:47

ci: fix node engine check (parse-community#7891)

9ef1968

fix: return correct response when revert is used in beforeSave (parse…

f63fb2b

…-community#7839)

perf: reduce database operations when using the constant parameter in…

48bd512

… Cloud Function validation (parse-community#7892)

feat: add MongoDB 5.1 compatibility (parse-community#7682)

90155cf

chore(release): 5.3.0-alpha.1 [skip ci]

499cead

# [5.3.0-alpha.1](parse-community/parse-server@5.2.1-alpha.2...5.3.0-alpha.1) (2022-03-27) ### Features * add MongoDB 5.1 compatibility ([parse-community#7682](parse-community#7682)) ([90155cf](parse-community@90155cf))

fix: security upgrade parse push adapter from 4.1.0 to 4.1.2 (parse-c…

ef56e98

…ommunity#7893)

feat: add MongoDB 5.2 support (parse-community#7894)

6b4b358

chore(release): 5.3.0-alpha.3 [skip ci]

75eca2d

# [5.3.0-alpha.3](parse-community/parse-server@5.3.0-alpha.2...5.3.0-alpha.3) (2022-03-27) ### Features * add MongoDB 5.2 support ([parse-community#7894](parse-community#7894)) ([6b4b358](parse-community@6b4b358))

Merge remote-tracking branch 'upstream/alpha' into alpha

61ef23f

Merge remote-tracking branch 'upstream/alpha' into alpha

606ed96

Merge branch 'alpha' of https://github.com/dblythy/parse-server into …

1e89817

…alpha

Merge remote-tracking branch 'upstream/alpha' into alpha

9720e8e

Merge remote-tracking branch 'upstream/alpha' into alpha

7bc5c36

Merge remote-tracking branch 'upstream/alpha' into alpha

7b2ab38

Merge remote-tracking branch 'upstream/alpha' into alpha

3c8f5cc

Merge remote-tracking branch 'upstream/alpha' into alpha

5814437

Merge remote-tracking branch 'upstream/alpha' into alpha

986c6c2

Merge remote-tracking branch 'upstream/alpha' into alpha

6a40dc4

Merge remote-tracking branch 'upstream/alpha' into alpha

a9fb355

fix: shutdown liveQuery server properly when handleShutdown is called

a563b21

parse-github-assistant bot changed the title ~~fix: shutdown liveQuery server properly when handleShutdown is called~~ fix: Shutdown liveQuery server properly when handleShutdown is called Mar 30, 2023

dblythy added 3 commits March 30, 2023 17:30

Update ParseLiveQuery.spec.js

f9263c1

tests

a133db4

Update ParseLiveQuery.spec.js

31c1b48

mtrezza changed the title ~~fix: Shutdown liveQuery server properly when handleShutdown is called~~ fix: LiveQuery server is not shut down properly when handleShutdown is called Apr 2, 2023

mtrezza reviewed Apr 2, 2023

View reviewed changes

src/LiveQuery/ParseLiveQueryServer.js Outdated Show resolved Hide resolved

rename

61f879d

Merge branch 'alpha' into shutdown-lq

0040e35

Merge branch 'alpha' into shutdown-lq

120f964

dblythy added 2 commits April 12, 2023 11:30

Merge remote-tracking branch 'upstream/alpha' into alpha

de8b8ea

Merge branch 'alpha' into shutdown-lq

0397538

Merge branch 'alpha' into shutdown-lq

e6aa2ca

Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>

Merge branch 'alpha' into shutdown-lq

91c0bdb

mtrezza approved these changes Jun 8, 2023

View reviewed changes

mtrezza merged commit 967700b into parse-community:alpha Jun 8, 2023

parseplatformorg added the state:released-alpha Released as alpha version label Jun 8, 2023

parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023

parseplatformorg added the state:released Released as stable version label Sep 16, 2023

Uh oh!

fix: LiveQuery server is not shut down properly when handleShutdown is called #8491

fix: LiveQuery server is not shut down properly when handleShutdown is called #8491

Uh oh!

Conversation

dblythy commented Mar 30, 2023

Pull Request

Issue

Approach

Tasks

Uh oh!

parse-github-assistant bot commented Mar 30, 2023

Uh oh!

parse-github-assistant bot commented Mar 30, 2023

Thanks for opening this pull request!

Uh oh!

codecov bot commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dplewis commented Apr 1, 2023

Uh oh!

Uh oh!

mtrezza commented Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dblythy commented Apr 11, 2023

Uh oh!

mtrezza commented Apr 11, 2023

Uh oh!

mtrezza commented Apr 11, 2023

Uh oh!

mtrezza commented Apr 14, 2023

Uh oh!

mtrezza commented Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dblythy commented Jun 8, 2023

Uh oh!

parseplatformorg commented Jun 8, 2023

Uh oh!

parseplatformorg commented Jun 10, 2023

Uh oh!

parseplatformorg commented Jun 18, 2023

Uh oh!

parseplatformorg commented Sep 16, 2023

Uh oh!

Uh oh!

fix: LiveQuery server is not shut down properly when `handleShutdown` is called #8491

fix: LiveQuery server is not shut down properly when `handleShutdown` is called #8491

codecov bot commented Mar 30, 2023 •

edited

Loading

mtrezza commented Apr 10, 2023 •

edited

Loading

mtrezza commented Jun 8, 2023 •

edited

Loading