Skip to content

feat: Add default ACL #8701

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 24, 2025
Merged

feat: Add default ACL #8701

merged 13 commits into from
Mar 24, 2025

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jul 24, 2023 •
edited
Loading

Pull Request

Issue

Closes: #7068

Approach

Adds the ability to set default ACL via class level permissions. Syntax is the JSON format of ACL, with the ability to add currentUser

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: add default acl feat: Add default acl Jul 24, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jul 24, 2023 •
edited
Loading

🚀 Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (b9917dd) to head (21b464e).
Report is 19 commits behind head on alpha.

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #8701   +/-   ##
=======================================
  Coverage   93.09%   93.10%           
=======================================
  Files         187      187           
  Lines       14998    15016   +18     
=======================================
+ Hits        13963    13981   +18     
  Misses       1035     1035

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dblythy dblythy requested a review from a team July 27, 2023 16:06
@mtrezza
Copy link
Member

mtrezza commented Jul 28, 2023

Could you add a more detailed description about what this PR does? The issue discussion is rather open and doesn't really spell out a specific approach.

  • It this a breaking change?
  • What does it change? We should probably add more details to the changelog entry for that as well.

@mtrezza mtrezza changed the title feat: Add default acl feat: Add default ACL Mar 6, 2025
@dblythy
Copy link
Member Author

dblythy commented Mar 20, 2025

Updated description

mtrezza
mtrezza reviewed Mar 20, 2025
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails

@dblythy dblythy requested a review from a team March 22, 2025 09:28
mtrezza
mtrezza approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a brief docs PR for this as well? Especially for the currentUser placeholder.

@dblythy
Copy link
Member Author

dblythy commented Mar 23, 2025

Where would you like me to document?

@mtrezza
Copy link
Member

mtrezza commented Mar 23, 2025 •
edited
Loading

It seems that this is a feature addition to the Defined Schema, right? So I'd suggest to add it there, in the docs repo.

@dblythy
Copy link
Member Author

dblythy commented Mar 24, 2025

Alright I will work on it there

@mtrezza mtrezza merged commit 12b5d78 into parse-community:alpha Mar 24, 2025
24 checks passed
parseplatformorg pushed a commit that referenced this pull request Mar 24, 2025
@semantic-release-bot
chore(release): 8.1.0-alpha.1 [skip ci]
bb74f02 
# [8.1.0-alpha.1](8.0.2...8.1.0-alpha.1) (2025-03-24)

### Features

* Add default ACL ([#8701](#8701)) ([12b5d78](12b5d78))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.1.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 24, 2025
parseplatformorg pushed a commit that referenced this pull request Apr 4, 2025
@semantic-release-bot
chore(release): 8.1.0 [skip ci]
4fb5bd7 
# [8.1.0](8.0.2...8.1.0) (2025-04-04)

### Bug Fixes

* Parse Server doesn't shutdown gracefully ([#9634](#9634)) ([aed918d](aed918d))

### Features

* Add Cloud Code triggers `Parse.Cloud.beforeFind(Parse.File)`and `Parse.Cloud.afterFind(Parse.File)` ([#8700](#8700)) ([b2beaa8](b2beaa8))
* Add default ACL ([#8701](#8701)) ([12b5d78](12b5d78))
* Upgrade Parse JS SDK from 6.0.0 to 6.1.0 ([#9686](#9686)) ([f49c371](f49c371))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Apr 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow option to set Default ACL
3 participants
@dblythy @mtrezza @parseplatformorg