Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

document ghost_zones=1 for restarts #1201

Open
BenWibking opened this issue Oct 29, 2024 · 3 comments
Open

document ghost_zones=1 for restarts #1201

BenWibking opened this issue Oct 29, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@BenWibking
Copy link
Collaborator

By default, ghost zones are not written/read in restarts. Adding ghost_zones=1 writes and reads them back in.

Docs: https://parthenon-hpc-lab.github.io/parthenon/develop/src/outputs.html#restart-files

@BenWibking BenWibking added the documentation Improvements or additions to documentation label Oct 29, 2024
@BenWibking BenWibking self-assigned this Oct 29, 2024
@Yurlungur
Copy link
Collaborator

It's worth adding this in the documentation but I am surprised this is ever needed. It might depend on the physics you're doing in your code. I think the ghost_zones flag is essentially for debugging.

@BenWibking
Copy link
Collaborator Author

It's worth adding this in the documentation but I am surprised this is ever needed. It might depend on the physics you're doing in your code. I think the ghost_zones flag is essentially for debugging.

It's needed because the gravitational potential is stored in a separate field, and its ghost zones are used in the hydro solver (but its values are only set in the initial conditions).

There might be a better way to handle this.

@Yurlungur
Copy link
Collaborator

It's worth adding this in the documentation but I am surprised this is ever needed. It might depend on the physics you're doing in your code. I think the ghost_zones flag is essentially for debugging.

It's needed because the gravitational potential is stored in a separate field, and its ghost zones are used in the hydro solver (but its values are only set in the initial conditions).

There might be a better way to handle this.

This might suggest we should have an upon-restart comms call on the base MeshData object. Since it's a one-time thing, cost should be minimal...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants