Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add config option to disable the error sample #6

Open
sanderboom opened this issue Jan 17, 2016 · 5 comments
Open

Add config option to disable the error sample #6

sanderboom opened this issue Jan 17, 2016 · 5 comments

Comments

@sanderboom
Copy link
Contributor

Having mario killed on every typo is just too much ;)

@DennisSnijder
Copy link
Contributor

options would be nice, but still.. just do not make errors @sanderboom :P

@sanderboom
Copy link
Contributor Author

ghehe, I was expecting a comment like this ;)

@pascaldevink
Copy link
Owner

I actually find it a great way to learn the git commands flawlessly and it improves my typing. Sort of Pavlov effect.

@Potherca
Copy link

Why not just copy the theme to a folder named smb-no-error, replace the error .wav with an empty file and adjust the config.json?[1]

1. No coding required == no new bugs + no extra code to maintain (and write unit tests for and document and have people complain about in the issues and, etc.)

@sanderboom
Copy link
Contributor Author

haha, sure.

What I did is set "error": "" in sounds.json. Many roads to Rome fortunately ;)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants