Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't send metrics with no value in nagios perfdata #26

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

flyingflo
Copy link

At least icinga2's GraphiteWriter fails to parse perfdata without values and spams the log with error messages like:

Ignoring invalid perfdata for checkable 'host1!ntpmon' and command 'ntpmon' with value: tracehosts=

Anyways, I'm not sure how other consumers of this data behave.

At least icinga2's GraphiteWriter fails to parse perfdata
without values and spams the log with error messages like:

"Ignoring invalid perfdata for checkable 'host1!ntpmon'
and command 'ntpmon' with value: tracehosts="
@paulgear
Copy link
Owner

Thanks for that - are any of the other metrics other than tracehosts which show up like this?

@flyingflo
Copy link
Author

flyingflo commented Nov 10, 2023

Thanks for that - are any of the other metrics other than tracehosts which show up like this?

Yes, all trace* metrics, because this check is disabled by default. If I disable other checks, their metrics are also reported without value and cause such a warning.

@paulgear
Copy link
Owner

Thanks for that - are any of the other metrics other than tracehosts which show up like this?

Yes, all trace* metrics, because this check is disabled by default. If I disable other checks, their metrics are also reported without value and cause such a warning.

Thanks. I don't think enough people rely on this package to worry about breaking backwards compatibility, and this is getting in the way of your deployment. I'll tag this as a new minor release hopefully this weekend.

@paulgear paulgear merged commit ee2b685 into paulgear:main Nov 11, 2023
@flyingflo
Copy link
Author

flyingflo commented Nov 11, 2023 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants