Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TagsForContentAtPath function doesn't work in GDScript. #92

Open
DeadManIV opened this issue Jun 1, 2024 · 2 comments
Open

TagsForContentAtPath function doesn't work in GDScript. #92

DeadManIV opened this issue Jun 1, 2024 · 2 comments
Labels
bug Something isn't working waiting for the next release This issue is resolved but waiting to be released

Comments

@DeadManIV
Copy link

DeadManIV commented Jun 1, 2024

Describe the bug
TagsForContentAtPath function doesn't work in GDScript. I think it's supposed to, cos this issue shows it working: #38
I receive the error:

Invalid call. Nonexistent function 'TagsForContentAtPath' in base 'Resource (InkStory)'.

To Reproduce
Call the function "TagsForContentAtPath" on an InkStory object in a GDScript file.

Environment

  • OS: Windows
  • Godot version: mono 4.2.2
  • godot-ink version: 1.1.2
  • ink version: 1.1.1

Additional context
Have had no other issues so far, using Ink in GDScript

@DeadManIV DeadManIV added the bug Something isn't working label Jun 1, 2024
@DeadManIV
Copy link
Author

DeadManIV commented Jun 1, 2024

My C# is pretty rusty but I fixed it by adding some code to InkStory.interop.cs:

/// <summary>
/// This method is here for GDScript compatibility. Use <see cref="TagsForContentAtPath" /> instead.
/// </summary>
[EditorBrowsable(EditorBrowsableState.Never)]
public Godot.Collections.Array<string> GetTagsForContentAtPath(string path)
{
    var tags = new Godot.Collections.Array<string>(TagsForContentAtPath(path));

    return tags;
}

@paulloz
Copy link
Owner

paulloz commented Jun 6, 2024

Thank you for the report, I'll fix this in the next release 👍

@paulloz paulloz added the waiting for the next release This issue is resolved but waiting to be released label Oct 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working waiting for the next release This issue is resolved but waiting to be released
Projects
None yet
Development

No branches or pull requests

2 participants