Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include newer version of is-glob #533

Closed
Jorenm opened this issue Sep 19, 2016 · 4 comments
Closed

Include newer version of is-glob #533

Jorenm opened this issue Sep 19, 2016 · 4 comments

Comments

@Jorenm
Copy link

Jorenm commented Sep 19, 2016

The version of is-glob that ^2.0.0 installs has issues with folders that contain parentheses. 3.0.0 is out and solves these issues.

@ficristo
Copy link

ficristo commented Feb 8, 2017

It seems to me the corresponding PR actually didn't upgrade the lib.
What happened?

@es128
Copy link
Contributor

es128 commented Feb 8, 2017

Oh I didn't notice the issue and PR were closed. The issues with windows haven't been resolved, and I accidentally pushed it to master at some point while working on something else - and then had to roll it back out.

@es128 es128 reopened this Feb 8, 2017
@ficristo
Copy link

Thank you @es128 for the explanation.
Is there some plan to fix this?
(I would like to help but I really doubt I can do much)

@Jorenm
Copy link
Author

Jorenm commented May 26, 2017

Here's the npm-shrinkwrap.json I used to fix this for now:

{
  "dependencies": {
    "chokidar": {
      "version": "1.6.1",
      "from": "chokidar@1.6.1",
      "dependencies": {
        "is-glob": {
          "version": "3.1.0",
          "from": "is-glob@2.0.1"
        }
      }
    }
  }
}

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants