Don't issue warning 210 in a few special cases:

* A variable is defined as a loop counter inside a 'for' loop.
* A variable is incremented/decremented using the '++'/'--' operator.

Author: Daniel-Cortez

source/compiler/sc1.c

@@ -5730,8 +5730,13 @@ static int dofor(void)
       /* The variable in expr1 of the for loop is at a
        * 'compound statement' level of it own.
        */
+      symbol *sym;
       nestlevel++;
       declloc(FALSE); /* declare local variable */
+      for (sym=loctab.next; sym!=NULL; sym=sym->next) {
+        if (sym->compound==nestlevel)
+          markinitialized(sym);
+      } /* for */
     } else {
       doexpr(TRUE,TRUE,TRUE,TRUE,NULL,NULL,FALSE);  /* expression 1 */
       needtoken(';');

source/compiler/sc3.c

@@ -1253,7 +1253,7 @@ static int hier2(value *lval)
     assert(lval->sym!=NULL);
     if ((lval->sym->usage & uCONST)!=0)
       return error(22);         /* assignment to const argument */
-    checkinitialized(lval->sym);
+    markinitialized(lval->sym);
     if (!check_userop(user_inc,lval->tag,0,1,lval,&lval->tag))
       inc(lval);                /* increase variable first */
     rvalue(lval);               /* and read the result into PRI */
@@ -1265,7 +1265,7 @@ static int hier2(value *lval)
     assert(lval->sym!=NULL);
     if ((lval->sym->usage & uCONST)!=0)
       return error(22);         /* assignment to const argument */
-    checkinitialized(lval->sym);
+    markinitialized(lval->sym);
     if (!check_userop(user_dec,lval->tag,0,1,lval,&lval->tag))
       dec(lval);                /* decrease variable first */
     rvalue(lval);               /* and read the result into PRI */
@@ -1516,7 +1516,7 @@ static int hier2(value *lval)
         assert(lval->sym!=NULL);
         if ((lval->sym->usage & uCONST)!=0)
           return error(22);     /* assignment to const argument */
-        checkinitialized(lval->sym);
+        markinitialized(lval->sym);
         /* on incrementing array cells, the address in PRI must be saved for
          * incremening the value, whereas the current value must be in PRI
          * on exit.
@@ -1539,7 +1539,7 @@ static int hier2(value *lval)
         assert(lval->sym!=NULL);
         if ((lval->sym->usage & uCONST)!=0)
           return error(22);     /* assignment to const argument */
-        checkinitialized(lval->sym);
+        markinitialized(lval->sym);
         saveresult= (lval->ident==iARRAYCELL || lval->ident==iARRAYCHAR);
         if (saveresult)
           pushreg(sPRI);        /* save address in PRI */

source/compiler/tests/warning_210.meta

@@ -3,29 +3,17 @@
   'errors': """
 warning_210.pwn(59) : warning 210: possible use of symbol before initialization: "local_var3"
 warning_210.pwn(62) : warning 210: possible use of symbol before initialization: "local_var4"
-warning_210.pwn(66) : warning 210: possible use of symbol before initialization: "local_var5"
-warning_210.pwn(70) : warning 210: possible use of symbol before initialization: "local_var6"
 warning_210.pwn(85) : warning 210: possible use of symbol before initialization: "local_arr1d4"
 warning_210.pwn(88) : warning 210: possible use of symbol before initialization: "local_arr1d5"
 warning_210.pwn(92) : warning 210: possible use of symbol before initialization: "local_arr1d6"
 warning_210.pwn(96) : warning 210: possible use of symbol before initialization: "local_arr1d7"
-warning_210.pwn(100) : warning 210: possible use of symbol before initialization: "local_arr1d8"
-warning_210.pwn(104) : warning 210: possible use of symbol before initialization: "local_arr1d9"
 warning_210.pwn(119) : warning 210: possible use of symbol before initialization: "local_arr2d4"
 warning_210.pwn(122) : warning 210: possible use of symbol before initialization: "local_arr2d5"
 warning_210.pwn(126) : warning 210: possible use of symbol before initialization: "local_arr2d6"
 warning_210.pwn(130) : warning 210: possible use of symbol before initialization: "local_arr2d7"
 warning_210.pwn(134) : warning 210: possible use of symbol before initialization: "local_arr2d8"
-warning_210.pwn(138) : warning 210: possible use of symbol before initialization: "local_arr2d9"
-warning_210.pwn(142) : warning 210: possible use of symbol before initialization: "local_arr2d10"
 warning_210.pwn(149) : warning 210: possible use of symbol before initialization: "global_var3"
-warning_210.pwn(151) : warning 210: possible use of symbol before initialization: "global_var4"
-warning_210.pwn(154) : warning 210: possible use of symbol before initialization: "global_var5"
 warning_210.pwn(165) : warning 210: possible use of symbol before initialization: "global_arr1d4"
-warning_210.pwn(167) : warning 210: possible use of symbol before initialization: "global_arr1d5"
-warning_210.pwn(170) : warning 210: possible use of symbol before initialization: "global_arr1d6"
 warning_210.pwn(181) : warning 210: possible use of symbol before initialization: "global_arr2d4"
-warning_210.pwn(184) : warning 210: possible use of symbol before initialization: "global_arr2d5"
-warning_210.pwn(187) : warning 210: possible use of symbol before initialization: "global_arr2d6"
   """
 }

source/compiler/tests/warning_210.pwn

@@ -63,11 +63,11 @@ TestFunc(arg_var, const arg_arr1d[], const arg_arr2d[][])
 	UseVariable(local_var4);
 
 	new local_var5;
-	++local_var5; // warning
+	++local_var5;
 	UseVariable(local_var5);
 
 	new local_var6;
-	local_var6++; // warning
+	local_var6++;
 	UseVariable(local_var6);
 
 	new local_arr1d1[] = "hi there!";
@@ -97,11 +97,11 @@ TestFunc(arg_var, const arg_arr1d[], const arg_arr2d[][])
 	Use1DArray(local_arr1d7);
 
 	new local_arr1d8[8];
-	++local_arr1d8[0]; // warning
+	++local_arr1d8[0];
 	Use1DArray(local_arr1d8);
 
 	new local_arr1d9[8];
-	local_arr1d9[0]++; // warning
+	local_arr1d9[0]++;
 	Use1DArray(local_arr1d9);
 
 	new local_arr2d1[2][8] = { { 0 }, ... };
@@ -135,11 +135,11 @@ TestFunc(arg_var, const arg_arr1d[], const arg_arr2d[][])
 	Use2DArray(local_arr2d8);
 
 	new local_arr2d9[2][8];
-	++local_arr2d9[0][0]; // warning
+	++local_arr2d9[0][0];
 	Use2DArray(local_arr2d9);
 
 	new local_arr2d10[2][8];
-	local_arr2d10[0][0]++; // warning
+	local_arr2d10[0][0]++;
 	Use2DArray(local_arr2d10);
 	UseVariable(global_var1);
 
@@ -148,10 +148,10 @@ TestFunc(arg_var, const arg_arr1d[], const arg_arr2d[][])
 
 	UseVariable(global_var3); // warning
 
-	++global_var4; // warning
+	++global_var4;
 	UseVariable(global_var4);
 
-	global_var5++; // warning
+	global_var5++;
 	UseVariable(global_var5);
 
 	Use1DArray(global_arr1d1);
@@ -164,10 +164,10 @@ TestFunc(arg_var, const arg_arr1d[], const arg_arr2d[][])
 
 	Use1DArray(global_arr1d4); // warning
 
-	++global_arr1d5[0]; // warning
+	++global_arr1d5[0];
 	Use1DArray(global_arr1d5);
 
-	global_arr1d6[0]++; // warning
+	global_arr1d6[0]++;
 	Use1DArray(global_arr1d6);
 
 	Use2DArray(global_arr2d1);
@@ -180,10 +180,10 @@ TestFunc(arg_var, const arg_arr1d[], const arg_arr2d[][])
 
 	Use2DArray(global_arr2d4); // warning
 
-	++global_arr2d5[0][0]; // warning
+	++global_arr2d5[0][0];
 	Use2DArray(global_arr2d5);
 
-	global_arr2d6[0][0]++; // warning
+	global_arr2d6[0][0]++;
 	Use2DArray(global_arr2d6);
 }