From b8dfd9f613850dfcf2731cb118f94f79970591fa Mon Sep 17 00:00:00 2001 From: NotedSalmon Date: Tue, 30 Jul 2024 16:32:30 +0100 Subject: [PATCH 1/3] FISH-8888 ClearCache command rest endpoint corrected I changed the parameter name to cache-name as the previous key was already being used which resulted in an error. --- .../java/fish/payara/nucleus/hazelcast/admin/ClearCache.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nucleus/payara-modules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java b/nucleus/payara-modules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java index f9a65d84a15..caa1a00c9ee 100644 --- a/nucleus/payara-modules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java +++ b/nucleus/payara-modules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java @@ -91,7 +91,7 @@ public class ClearCache implements AdminCommand { @Param(name = "target", optional = true, defaultValue = "server") protected String target; - @Param(name = "name", defaultValue = "") + @Param(name = "cache-name", defaultValue = "") protected String cacheName; @Param(name = "key", optional = true) From 4cf2e3305c7b730bbb2bafa1a5c14e468532853a Mon Sep 17 00:00:00 2001 From: Flavio <94856026+NotedSalmon@users.noreply.github.com> Date: Fri, 2 Aug 2024 16:09:40 +0100 Subject: [PATCH 2/3] FISH-8888 better naming as suggested. Co-authored-by: Andrew Pielage --- .../java/fish/payara/nucleus/hazelcast/admin/ClearCache.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nucleus/payara-modules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java b/nucleus/payara-modules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java index caa1a00c9ee..b1782a8b0b6 100644 --- a/nucleus/payara-modules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java +++ b/nucleus/payara-modules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java @@ -91,7 +91,7 @@ public class ClearCache implements AdminCommand { @Param(name = "target", optional = true, defaultValue = "server") protected String target; - @Param(name = "cache-name", defaultValue = "") + @Param(name = "cacheName", alias = "cachename", defaultValue = "") protected String cacheName; @Param(name = "key", optional = true) From 7cda1214b5d73a5637bd3a78f2c0e89587671536 Mon Sep 17 00:00:00 2001 From: NotedSalmon Date: Fri, 2 Aug 2024 17:24:32 +0100 Subject: [PATCH 3/3] FISH-8888 ClearCache command rest endpoint corrected Changed method to POST --- .../java/fish/payara/nucleus/hazelcast/admin/ClearCache.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nucleus/payara-modules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java b/nucleus/payara-modules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java index b1782a8b0b6..e7a98a00760 100644 --- a/nucleus/payara-modules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java +++ b/nucleus/payara-modules/hazelcast-bootstrap/src/main/java/fish/payara/nucleus/hazelcast/admin/ClearCache.java @@ -76,7 +76,7 @@ @TargetType(value = {CommandTarget.DAS, CommandTarget.STANDALONE_INSTANCE, CommandTarget.CLUSTER, CommandTarget.CLUSTERED_INSTANCE, CommandTarget.CONFIG, CommandTarget.DEPLOYMENT_GROUP}) @RestEndpoints({ @RestEndpoint(configBean = Domain.class, - opType = RestEndpoint.OpType.GET, + opType = RestEndpoint.OpType.POST, path = "clear-cache", description = "Clears a JCache or Hazalcast IMap") })