From 20477f5d04bf804ffc3139a890a12f57f20f3418 Mon Sep 17 00:00:00 2001 From: Petr Aubrecht Date: Mon, 16 Dec 2024 13:09:12 +0100 Subject: [PATCH 1/5] FISH-10299 upgrade selenium libs to the latest version --- faces-tck/pom.xml | 2 +- faces-tck/pom.xml-tck-util | 85 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 86 insertions(+), 1 deletion(-) create mode 100755 faces-tck/pom.xml-tck-util diff --git a/faces-tck/pom.xml b/faces-tck/pom.xml index 41f95bc..d3a260c 100644 --- a/faces-tck/pom.xml +++ b/faces-tck/pom.xml @@ -40,8 +40,8 @@ ${user.home}/.m2/settings.xml -B -e -s ${maven.settings.xml} -f ${tck.root}/faces-tck-${faces.version}/tck/pom.xml - clean install -Ppayara-ci-remote -P!glassfish-ci-managed -Dpayara.version=${payara.version} -Dfaces.version=${faces.version} -Dsigtest.api.groupId=org.glassfish -Dsigtest.api.artifactId=jakarta.faces -Dsigtest.api.version=${sigtest.api.version} -Dpayara.arquillian.version=${payara.arquillian.version} + clean install verify diff --git a/faces-tck/pom.xml-tck-util b/faces-tck/pom.xml-tck-util new file mode 100755 index 0000000..d2591eb --- /dev/null +++ b/faces-tck/pom.xml-tck-util @@ -0,0 +1,85 @@ + + + + 4.0.0 + + + org.eclipse.ee4j.faces.tck + jakarta-faces-tck + 4.1.1 + + + org.eclipse.ee4j.tck.faces.test + util + + Jakarta Faces TCK ${project.version} - Test - Util + + + + junit + junit + compile + + + org.jboss.arquillian.junit + arquillian-junit-container + + + org.seleniumhq.selenium + selenium-java + 4.27.0 + + + org.seleniumhq.selenium + selenium-chrome-driver + 4.27.0 + + + commons-lang + commons-lang + 2.6 + + + io.github.bonigarcia + webdrivermanager + 5.9.2 + + + org.jboss.shrinkwrap.resolver + shrinkwrap-resolver-impl-maven + + + org.jboss.shrinkwrap.resolver + shrinkwrap-resolver-impl-maven-archive + + + org.eu.ingwar.tools + arquillian-suite-extension + 1.2.0 + + + + net.sourceforge.htmlunit + htmlunit + 2.70.0 + + + From edfb8fa5e3a3f5d7ffdbda5d919ef2131b62784f Mon Sep 17 00:00:00 2001 From: Petr Aubrecht Date: Mon, 16 Dec 2024 13:10:07 +0100 Subject: [PATCH 2/5] FISH-10299 simplify the local runner --- faces-tck/run-tck.sh | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/faces-tck/run-tck.sh b/faces-tck/run-tck.sh index 125335c..71a87ab 100755 --- a/faces-tck/run-tck.sh +++ b/faces-tck/run-tck.sh @@ -1,11 +1,17 @@ #!/bin/bash -if [ JAVA_HOME = "" ] ; then +#if [ JAVA_HOME = "" ] ; then export JAVA_HOME=/usr/lib/jvm/java-21-openjdk-amd64 -fi +#fi + +#echo "Downloading Faces TCK" +#cd .. +#mvn clean install -pl .,:tck-download,:jakarta-faces-tck +#cd faces-tck + +#echo "Building old tck, expected time 3-7 minutes" +#cd target/faces-tck-4.1.1/tck/old-tck +#mvn clean install -Dtck.mode=platform -Dmojarra.noupdate=true -Dpayara.version=7.2024.1.Alpha2 -Dfaces.version=4.1.1 -pl :old-faces-tck-parent,:old-tck-build | tee ../../../old-tck.log +#cd .. -echo "Downloading Faces TCK" -cd .. -mvn clean install -pl .,:tck-download,:jakarta-faces-tck -cd faces-tck mvn clean verify From 5202016d5520ab214606b0d0bf68f5962c20485b Mon Sep 17 00:00:00 2001 From: Petr Aubrecht Date: Tue, 17 Dec 2024 15:55:58 +0100 Subject: [PATCH 3/5] FISH-10299 copy the updated tck util pom.xml --- faces-tck/pom.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/faces-tck/pom.xml b/faces-tck/pom.xml index d3a260c..cda1de9 100644 --- a/faces-tck/pom.xml +++ b/faces-tck/pom.xml @@ -107,6 +107,10 @@ + Upgrade Selenium libs to latest Chrome + From 4cef7e3973b82e5f843ed78ae98f2d41f3a7bad9 Mon Sep 17 00:00:00 2001 From: Petr Aubrecht Date: Tue, 17 Dec 2024 15:57:59 +0100 Subject: [PATCH 4/5] FISH-10299 upgrade chrome dependency to 131 The TCK is written for Chrome 124.*, but the current version is 131. This commit upgrades the dependency, first using the selenium dev tools and then rewriting java test imports. --- faces-tck/pom.xml | 27 +++++++++++++++++++++++++++ faces-tck/pom.xml-tck-util | 5 +++++ 2 files changed, 32 insertions(+) diff --git a/faces-tck/pom.xml b/faces-tck/pom.xml index cda1de9..d97908f 100644 --- a/faces-tck/pom.xml +++ b/faces-tck/pom.xml @@ -116,6 +116,33 @@ + + com.google.code.maven-replacer-plugin + replacer + 1.5.3 + + + replace-selenium-driver-version + pre-integration-test + + replace + + + false + + ${project.build.directory}/faces-tck-${faces.version}/tck/util/src/main/java/ee/jakarta/tck/faces/test/util/selenium/ChromeDevtoolsDriver.java + + + + + devtools.v124.network + devtools.v131.network + + + + + + org.codehaus.mojo exec-maven-plugin diff --git a/faces-tck/pom.xml-tck-util b/faces-tck/pom.xml-tck-util index d2591eb..8e7dfee 100755 --- a/faces-tck/pom.xml-tck-util +++ b/faces-tck/pom.xml-tck-util @@ -52,6 +52,11 @@ selenium-chrome-driver 4.27.0 + + org.seleniumhq.selenium + selenium-devtools-v131 + 4.27.0 + commons-lang commons-lang From a111f96c38fae4e6f6e9c4b8ec5cd6bc2692fcf6 Mon Sep 17 00:00:00 2001 From: Petr Aubrecht Date: Wed, 18 Dec 2024 14:47:02 +0100 Subject: [PATCH 5/5] FISH-10299 removing verify as it is implied by install Co-authored-by: Andrew Pielage --- faces-tck/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/faces-tck/pom.xml b/faces-tck/pom.xml index d97908f..a0c53ac 100644 --- a/faces-tck/pom.xml +++ b/faces-tck/pom.xml @@ -41,7 +41,7 @@ -B -e -s ${maven.settings.xml} -f ${tck.root}/faces-tck-${faces.version}/tck/pom.xml -Ppayara-ci-remote -P!glassfish-ci-managed -Dpayara.version=${payara.version} -Dfaces.version=${faces.version} -Dsigtest.api.groupId=org.glassfish -Dsigtest.api.artifactId=jakarta.faces -Dsigtest.api.version=${sigtest.api.version} -Dpayara.arquillian.version=${payara.arquillian.version} - clean install verify + clean install