fix(plugin-multi-tenant): prevent throwing when no user exists #10699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarrodMFlesch
changed the title
JarrodMFlesch
changed the title
JarrodMFlesch
changed the title
JarrodMFlesch
changed the title
JarrodMFlesch
changed the title
|
🚀 This is included in version v3.19.0 |
kendelljoseph
pushed a commit
that referenced
this pull request
Feb 21, 2025
### What? Fixes issue where the provider would throw an error and prevent the login screen from loading if there was no user. ### Why? Missing try/catch around tenant find for the provider. (Missed because test suites have autoLogin: true) ### How? Adds try/catch around find query.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes issue where the provider would throw an error and prevent the login screen from loading if there was no user.
Why?
Missing try/catch around tenant find for the provider. (Missed because test suites have autoLogin: true)
How?
Adds try/catch around find query.
Fixes #10602
Fixes #10714