feat(pickState): only pick relevant state #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `toggleMenu` and friends more user-friendly by only picking out state that is relevant to downshift, allowing users to use them as event event handlers. See #182.
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 267 277 +10
Branches 64 65 +1
=====================================
+ Hits 267 277 +10
Continue to review full report at Codecov.
|
kentcdodds
reviewed
Sep 10, 2017
| @@ -154,6 +155,7 @@ class Downshift extends Component { | |||
| highlightedIndex = this.props.defaultHighlightedIndex, | |||
| otherStateToSet = {}, | |||
| ) => { | |||
| otherStateToSet = pickState(otherStateToSet) | |||
There was a problem hiding this comment.
Actually, I think this is the only place we really need this function called because all the other code paths lead here. Try removing the other changes and see if this works. I think it will.
There was a problem hiding this comment.
I just tried this, and it didn't work for me. I also tried to move this further down into internalSetState, and that didn't remove the warnings either.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
toggleMenuand friends more user-friendly by only picking outstate that is relevant to downshift, allowing users to use them as event
event handlers. See #182.
What: Make
toggleMenuand friends more user-friendly.Why: See #182.
How: Add
pickStateand call it whenever we are about to spreadotherStateToSetintointernalSetStateChecklist:
Additional comments:
When I initially pulled the most recent from master,
npm run validatefailed.I investigated a bit. Only the
build-and-testtask is failing.lint,test:cover, andtest:tssucceed. I decided to ignore it while developing because I could still run the other test tasks, thinking it could just be a problem with my machine. Please let me know if we should address this first.I wanted to add direct tests on
toggleMenuand others todownshift.misc.js(in addition to addingutils.pick-state.js), but there wasn't a way to test what object was being passed tointernalSetState. No matter what the internal state is, we always pass the correct keys torender(https://github.com/paypal/downshift/blob/master/src/downshift.js#L336). So, with the current test setup, I couldn't find a way to see what the internals were. I decided it was OK, thinking the new test was sufficient, but let me know if you think otherwise.Locally, I added a new story to test the changes. It didn't seem appropriate to include it in the commit, but let me know if you think otherwise.