Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(esm): fix path to ES module #197

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

garrettn
Copy link
Contributor

What: Updating jsnext:main and module in package.json to use the correct path to the ES module.

Why: I was getting errors in ESLint because the import plugin was unable to find the module. My project actually built just fine, but the linting failed. This change makes ESLint happy.

How: Changing those fields in the package file.

Checklist:

  • Documentation N/A
  • Tests N/A? (see below)
  • Ready to be merged
  • Added myself to contributors table

The build test was also failing because it had an incorrect path to the module, so I fixed that as well. Running npm run build-and-test had two failures: one for this problem, and one for the preact build. I tried fixing the preact path as well but then got other failures I wasn't sure how to fix.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Thank you!

@kentcdodds kentcdodds merged commit 1c952ff into downshift-js:master Sep 22, 2017
@garrettn garrettn deleted the fix-module-path branch September 22, 2017 17:42
@codecov-io
Copy link

Codecov Report

Merging #197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #197   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         267    267           
  Branches       61     61           
=====================================
  Hits          267    267

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70f602b...f7cf617. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants