Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Not compatible with current prom-client API #2

Closed
dobesv opened this issue Apr 17, 2020 · 2 comments · Fixed by #4
Closed

Not compatible with current prom-client API #2

dobesv opened this issue Apr 17, 2020 · 2 comments · Fixed by #4

Comments

@dobesv
Copy link

dobesv commented Apr 17, 2020

The current version of prom-client requires the parameters to Guage to be an object specifying the information as a single argument instead of three arguments.
@pbadenski
Copy link
Collaborator

Could you send a pull request? I don't have the capacity to add this feature at the moment...

@dobesv
Copy link
Author

dobesv commented Apr 19, 2020

Eh, no I just reimplemented the metrics. I don't have time, either. I guess this issue can at least be here for reference.

@robbiet480 robbiet480 mentioned this issue May 27, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modernize FlatFilers/bull-prom
2 participants
@pbadenski @dobesv