Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expand Client API for Update and Similar Operations #209

Open
ZLLentz opened this issue Feb 2, 2021 · 0 comments
Open

Expand Client API for Update and Similar Operations #209

ZLLentz opened this issue Feb 2, 2021 · 0 comments

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Feb 2, 2021

Expected Behavior

Two additions to the Client API:

  • Client.update(dict) that performs the operations used in happi update <json> #207, but on the Client class. Accompany with a refactor to have the CLI arg simply call the new method.
  • add exist_ok=False argument to Client.add_device so features like happi update <json> #207 can entirely use the public API

Current Behavior

No such API

Possible Solution

Add them, or something equivalently helpful after some discussion

Context

#207 needed to use the private API to accomplish its goals

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant