Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

How to test a new method implementation? #15

Open
paladini opened this issue Sep 29, 2015 · 0 comments
Open

How to test a new method implementation? #15

paladini opened this issue Sep 29, 2015 · 0 comments

Comments

@paladini
Copy link

Hi,

I'm improving your library adding support for gzipped (compressed / batch) write on KairosDB. I've modified the write_metrics_list to:

def write_metrics_list(conn, metric_list, _gzip=False):

Then I write the following code inside test_writer.py:

# Test batch write (compressed) 
data = [
    {
        "name": "test1",
        "timestamp": 1349109376,
        "value": 20,
        "tags":{"host":"test"}
    },
    {
        "name": "test2",
        "timestamp": 1349109374,
        "value": 23,
        "tags":{"host":"test"}
    }
]
r = c.write_metrics_list(c, data, True)

I run python setup.py build and python setup.py install and later python pyKairosDB/tests/test_writer.py. But when I try to test that I got a issue:

[paladini@starstuff tests]$ python test_writer.py 
Traceback (most recent call last):
  File "test_writer.py", line 26, in <module>
    r = c.write_metrics_list(c, data, True)
AttributeError: 'KairosDBConnection' object has no attribute 'write_metrics_list'

Can you help me with that? After that, I can make a pull request :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant