Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update runtimes to polkadot-v0.9.40 #219

Closed
ebma opened this issue Apr 19, 2023 · 15 comments · Fixed by pendulum-chain/spacewalk#350 or #242
Closed

Update runtimes to polkadot-v0.9.40 #219

ebma opened this issue Apr 19, 2023 · 15 comments · Fixed by pendulum-chain/spacewalk#350 or #242
Assignees
Labels

Comments

@ebma
Copy link
Member

ebma commented Apr 19, 2023

We should update our runtime dependencies to version polkadot-v0.9.38 so that we get rid of some dependency conflicts.
For example, we were running into problems because our spacewalk pallets use jsonrpsee with version >0.16.0 but other parachain pallets that are on polkadot-v0.9.37 still use jsonrpsee version 0.15.x (e.g. Zenlink) which then leads to conflicts when importing RPC modules from their pallets.

@ebma ebma added the priority:medium Do it soon label Apr 19, 2023
@vadaynujra
Copy link

@TorstenStueber
Copy link
Contributor

Maybe it makes sense to even switch to Polkadot version 0.9.40 now – it is already supported by orml.

This would also require a follow up task to not just execute the runtime upgrade but first to redeploy all of our collator nodes.

@ebma
Copy link
Member Author

ebma commented May 2, 2023

Sure, we'd just need to double-check the jsonrpsee dependencies but if there is a mismatch, then probably just because the version used in the spacewalk pallets is 'too old' which we can fix easily.

@vadaynujra vadaynujra changed the title Update runtimes to polkadot-v0.9.38 Update runtimes to polkadot-v0.9.40 May 3, 2023
@TorstenStueber
Copy link
Contributor

I created a polkadot-v0.9.40 branch in substrate-stellar-sdk repository so that we are good to go from that side. Probably also need to update dependencies in the other related dependencies:

@TorstenStueber
Copy link
Contributor

For that reason I want to re-estimate. @vadaynujra is such a feature not available (change an estimate)?

@b-yap b-yap self-assigned this May 12, 2023
@b-yap
Copy link
Contributor

b-yap commented May 15, 2023

@b-yap
Copy link
Contributor

b-yap commented May 15, 2023

Yes I would think this will be higher than 3. The jump from .37 to .40 is huge.

A few changes I found:

And there's plenty more.
Currently on https://github.com/pendulum-chain/oracle-pallet.

@TorstenStueber
Copy link
Contributor

@b-yap yes, also including Spacewalk of course. Seems like I have the power to change the estimate. Shall we change it to 5 then @b-yap, or even 8?

@b-yap
Copy link
Contributor

b-yap commented May 17, 2023

8 would be fine.

@TorstenStueber
Copy link
Contributor

Alright, done.

@Curu24
Copy link

Curu24 commented May 26, 2023

Hello, will this include --rpc-relay-chain-url functionality?

@TorstenStueber
Copy link
Contributor

@Curu24 Is this a new feature introduced in Substrate recently? Can you refer to it please?

@Curu24
Copy link

Curu24 commented May 29, 2023

@Curu24 Is this a new feature introduced in Substrate recently? Can you refer to it please?

paritytech/cumulus#1585

@TorstenStueber
Copy link
Contributor

Since this feature has been merged already many months ago, it is already included in the polkadot-v0.9.31 branch.

So, it looks to me like the Pendulum nodes would already include this functionality even without this PR.

@Curu24
Copy link

Curu24 commented May 29, 2023

Since this feature has been merged already many months ago, it is already included in the polkadot-v0.9.31 branch.

So, it looks to me like the Pendulum nodes would already include this functionality even without this PR.

Oh, yes, sorry. You're right. I was trying with the older release 0.9.29. With 0.9.37 it works.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
5 participants