Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Transactions table should populate recent transactions first #1363

Closed
turbocrime opened this issue Jun 28, 2024 · 4 comments
Closed

Transactions table should populate recent transactions first #1363

turbocrime opened this issue Jun 28, 2024 · 4 comments
Labels
bug Something isn't working idb idb access, schema, or interface performance Related to speed improvements refactor Improving existing system with new design ui Related to user interface or ux design

Comments

@turbocrime
Copy link
Collaborator

On the minifront transactions table, transaction info is streamed to the page.

They populate in essentially random order: they stream in lexical order of their key, which is a base64 encoding of their transaction hash.

Ideally, the most recent transactions known would populate first, and earlier transactions would load as the user scrolls down the page.

@turbocrime
Copy link
Collaborator Author

I experimented with this issue today. Unfortunately it looks like this is impossible given current idb schema constraints

  1. we should add an index of transactions by height. this is doable.
  2. we should query by this index. this is doable.

But, the index is also a string which sorts in lexical order, because the height in database is a jsonified bigint.

The situation is improved but still clearly incorrect.

Screen.Recording.2024-06-27.at.22.44.46.mov

@turbocrime
Copy link
Collaborator Author

if idb schema used real types instead of stringifying everything, many operations like this would be more sane and just work as expected.

@turbocrime
Copy link
Collaborator Author

if the string key bounds are interpreted lexically instead of numerically, it may not even be possible to achieve numeric ranges with idb key bounds. this could create problems long term.

@turbocrime turbocrime added bug Something isn't working ui Related to user interface or ux design refactor Improving existing system with new design performance Related to speed improvements idb idb access, schema, or interface labels Aug 2, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Labs web Aug 15, 2024
@TalDerei TalDerei self-assigned this Jan 7, 2025
@TalDerei TalDerei removed their assignment Jan 16, 2025
@TalDerei
Copy link
Contributor

TalDerei commented Feb 4, 2025

closed by #1996 and more improvements in #2009

@TalDerei TalDerei closed this as completed Feb 4, 2025
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra Web + Not Web Feb 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working idb idb access, schema, or interface performance Related to speed improvements refactor Improving existing system with new design ui Related to user interface or ux design
Projects
Archived in project
Development

No branches or pull requests

2 participants