Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve the logic of CommandRouteParser for separators #86

Open
perpetualintelligencegit opened this issue Sep 22, 2023 · 0 comments
Open
Assignees

Comments

@perpetualintelligencegit
Copy link
Contributor

perpetualintelligencegit commented Sep 22, 2023

Describe the bug
These tests should fail:
Value_Separators_In_Between_Are_Ignored
Duplicate_Value_Separators_In_Between_Are_Ignored
Mixed_Duplicate_Value_Separators_In_Between_Are_Ignored

Our current logic uses separator and valueSeparation to split the command string. This is not an issue if both are the same e.g. " ".

If both values are different (e..g " " and "=") then this has an unexpected consequence. We end up ignoring an invalid command string. root1=grp1=cmd1 --opt3=\"option delimited value3\"

This should be an error as the command and arguments are still required to be separated by " ".

@perpetualintelligencegit perpetualintelligencegit changed the title Improve the logic doe CommandRouteParser for separators Improve the logic of CommandRouteParser for separators Sep 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants