Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support GitHub Enterprise Server #704

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Support GitHub Enterprise Server #704

merged 2 commits into from
Jan 26, 2021

Conversation

jonico
Copy link
Contributor

@jonico jonico commented Jan 25, 2021

  • only minimal changes are needed to support GitHub Enterprise with this action
  • use GITHUB_SERVER_URL and GITHUB_API_URL in all places that have been github.com specific before
  • successfully tested with GitHub Enterprise Server 2.22

jonico added 2 commits January 25, 2021 18:25
@jonico
Support GitHub Enterprise Server
adc6552 
* parse GITHUB_SERVER_URL if present
* accept proper server remotes as well
@jonico
Support GitHub Server API URL
05bc467 
* pass GitHub Server API in Octokkit constructor
@peter-evans
Copy link
Owner

This is great. Thank you for contributing!

@peter-evans
Copy link
Owner

peter-evans commented Jan 26, 2021 •
edited by actions-bot
Loading

/test repository=jonico/create-pull-request ref=support-ghes build=true

Command run output

@peter-evans
Copy link
Owner

All tests pass. Merging.

@peter-evans peter-evans merged commit 2455e15 into peter-evans:master Jan 26, 2021
@peter-evans
Copy link
Owner

Released as v3.7.0. Thank you!

@jonico jonico deleted the support-ghes branch January 26, 2021 10:27
This was referenced Mar 10, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonico @peter-evans