Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CTransaction.stream_deserialize allows empty witness record when witness is signalled #221

Open
dgpv opened this issue Dec 31, 2019 · 0 comments

Comments

@dgpv
Copy link
Contributor

dgpv commented Dec 31, 2019

in CTransaction.stream_deserialize(), if it detects that witness is signalled, it just tries to deserialize the witness and does not check if it is null. Core has a check in this case:

         if (!tx.HasWitness()) {
            /* It's illegal to encode witnesses when all witness stacks are empty. */
            throw std::ios_base::failure("Superfluous witness record");
        }
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant