better not implemented messages (#889)

Denchick · web-flow · commit 2e569d861e5e · 2024-12-24T19:15:10.000+05:00
diff --git a/coordinator/provider/coordinator.go b/coordinator/provider/coordinator.go
@@ -1878,7 +1878,7 @@ func (qc *qdbCoordinator) AddDataShard(ctx context.Context, shard *datashards.Da
 }
 
 func (qc *qdbCoordinator) AddWorldShard(_ context.Context, _ *datashards.DataShard) error {
-	panic("implement me")
+	panic("qdbCoordinator.AddWorldShard not implemented")
 }
 
 func (qc *qdbCoordinator) DropShard(ctx context.Context, shardId string) error {
diff --git a/coordinator/provider/shards.go b/coordinator/provider/shards.go
@@ -38,7 +38,7 @@ func (s *ShardServer) AddDataShard(ctx context.Context, request *protos.AddShard
 }
 
 func (s *ShardServer) AddWorldShard(ctx context.Context, request *protos.AddWorldShardRequest) (*emptypb.Empty, error) {
-	panic("implement me")
+	panic("ShardServer.AddWorldShard not implemented")
 }
 
 // TODO : unit tests
diff --git a/pkg/coord/adapter.go b/pkg/coord/adapter.go
@@ -46,11 +46,11 @@ func NewAdapter(conn *grpc.ClientConn) *Adapter {
 // Returns:
 // - qdb.QDB: The QDB object.
 func (a *Adapter) QDB() qdb.QDB {
-	panic("implement me?")
+	panic("Adapter.QDB not implemented")
 }
 
 func (a *Adapter) Cache() *cache.SchemaCache {
-	panic("implement me?")
+	panic("Adapter.Cache not implemented")
 }
 
 // TODO : unit tests
diff --git a/router/grpc/qrouter.go b/router/grpc/qrouter.go
@@ -62,8 +62,7 @@ func (l *LocalQrouterServer) AddDataShard(ctx context.Context, request *protos.A
 }
 
 func (l *LocalQrouterServer) AddWorldShard(ctx context.Context, request *protos.AddWorldShardRequest) (*emptypb.Empty, error) {
-	//TODO implement me
-	panic("implement me")
+	panic("LocalQrouterServer.AddWorldShard not implemented")
 }
 
 func (l *LocalQrouterServer) GetShard(ctx context.Context, request *protos.ShardRequest) (*protos.ShardReply, error) {
@@ -183,8 +182,7 @@ func (l *LocalQrouterServer) GetRouterStatus(ctx context.Context, _ *emptypb.Emp
 
 // TODO : implement, unit tests
 func (l *LocalQrouterServer) CloseRouter(ctx context.Context, _ *emptypb.Empty) (*emptypb.Empty, error) {
-	//TODO implement me
-	panic("implement me")
+	panic("LocalQrouterServer.CloseRouter not implemented")
 }
 
 // TODO : unit tests
diff --git a/router/server/multishard.go b/router/server/multishard.go
@@ -453,8 +453,7 @@ func (m *MultiShardServer) Cleanup(rule config.FrontendRule) error {
 }
 
 func (m *MultiShardServer) Sync() int64 {
-	//TODO implement me
-	panic("implement me")
+	panic("MultiShardServer.Sync not implemented")
 }
 
 func (m *MultiShardServer) Cancel() error {

Original file line number	Diff line number	Diff line change
`@@ -1878,7 +1878,7 @@ func (qc qdbCoordinator) AddDataShard(ctx context.Context, shard datashards.Da`
`1878`	`1878`	`}`
`1879`	`1879`
`1880`	`1880`	`func (qc qdbCoordinator) AddWorldShard(_ context.Context, _ datashards.DataShard) error {`
`1881`		`- panic("implement me")`
	`1881`	`+ panic("qdbCoordinator.AddWorldShard not implemented")`
`1882`	`1882`	`}`
`1883`	`1883`
`1884`	`1884`	`func (qc *qdbCoordinator) DropShard(ctx context.Context, shardId string) error {`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ func (s ShardServer) AddDataShard(ctx context.Context, request protos.AddShard`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`func (s ShardServer) AddWorldShard(ctx context.Context, request protos.AddWorldShardRequest) (*emptypb.Empty, error) {`
`41`		`- panic("implement me")`
	`41`	`+ panic("ShardServer.AddWorldShard not implemented")`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`// TODO : unit tests`
Original file line number	Diff line number	Diff line change
`@@ -46,11 +46,11 @@ func NewAdapter(conn grpc.ClientConn) Adapter {`
`46`	`46`	`// Returns:`
`47`	`47`	`// - qdb.QDB: The QDB object.`
`48`	`48`	`func (a *Adapter) QDB() qdb.QDB {`
`49`		`- panic("implement me?")`
	`49`	`+ panic("Adapter.QDB not implemented")`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`func (a Adapter) Cache() cache.SchemaCache {`
`53`		`- panic("implement me?")`
	`53`	`+ panic("Adapter.Cache not implemented")`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`// TODO : unit tests`
Original file line number	Diff line number	Diff line change
`@@ -62,8 +62,7 @@ func (l LocalQrouterServer) AddDataShard(ctx context.Context, request protos.A`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`func (l LocalQrouterServer) AddWorldShard(ctx context.Context, request protos.AddWorldShardRequest) (*emptypb.Empty, error) {`
`65`		`- //TODO implement me`
`66`		`- panic("implement me")`
	`65`	`+ panic("LocalQrouterServer.AddWorldShard not implemented")`
`67`	`66`	`}`
`68`	`67`
`69`	`68`	`func (l LocalQrouterServer) GetShard(ctx context.Context, request protos.ShardRequest) (*protos.ShardReply, error) {`
`@@ -183,8 +182,7 @@ func (l LocalQrouterServer) GetRouterStatus(ctx context.Context, _ emptypb.Emp`
`183`	`182`
`184`	`183`	`// TODO : implement, unit tests`
`185`	`184`	`func (l LocalQrouterServer) CloseRouter(ctx context.Context, _ emptypb.Empty) (*emptypb.Empty, error) {`
`186`		`- //TODO implement me`
`187`		`- panic("implement me")`
	`185`	`+ panic("LocalQrouterServer.CloseRouter not implemented")`
`188`	`186`	`}`
`189`	`187`
`190`	`188`	`// TODO : unit tests`
Original file line number	Diff line number	Diff line change
`@@ -453,8 +453,7 @@ func (m *MultiShardServer) Cleanup(rule config.FrontendRule) error {`
`453`	`453`	`}`
`454`	`454`
`455`	`455`	`func (m *MultiShardServer) Sync() int64 {`
`456`		`- //TODO implement me`
`457`		`- panic("implement me")`
	`456`	`+ panic("MultiShardServer.Sync not implemented")`
`458`	`457`	`}`
`459`	`458`
`460`	`459`	`func (m *MultiShardServer) Cancel() error {`