Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Small console messages #398

Closed
Denchick opened this issue Jan 15, 2024 · 1 comment
Closed

Small console messages #398

Denchick opened this issue Jan 15, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Denchick
Copy link
Collaborator

Denchick commented Jan 15, 2024

Have a look

ADD SHARDING RULE r2 COLUMNS w_id FOR DATASPACE ds2;
                                    add sharding rule                                    
-----------------------------------------------------------------------------------------
 created sharding rule r2 for table (*) with columns [w_id, hash: x->x] in ds2 dataspace
(1 row)

Why are these response messages so long? Let's make it a bit smaller, something like

ADD SHARDING RULE r2 COLUMNS w_id FOR DATASPACE ds2;
                   add sharding rule r2                                   
------------------------------------------------------------
 table (*) with columns [w_id, hash: x->x] in ds2 dataspace
(1 row)

But to be honest, it's still hard to read. What do you think?

ADD SHARDING RULE r2 COLUMNS w_id FOR DATASPACE 
  NEW SHARDING RULE
---------------------------------
 rule id   -> r2
 table     -> (*)
 columns   -> [w_id, hash: x->x]
 dataspace -> ds2
(1 row)

Any ideas?

@Denchick Denchick changed the title Smaller console messages Small console messages Jan 15, 2024
@CBists
Copy link
Collaborator

CBists commented Jan 15, 2024

I prefer the second option, but instead of "ValueName -> value", use "ValueName: value"

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants