Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removing pgr_ prefix & some formatting & cleanup #55

Merged
merged 16 commits into from
Aug 8, 2024

Conversation

cvvergara
Copy link
Member

@cvvergara cvvergara commented Aug 6, 2024

Changes proposed in this pull request:

  • PickDeliveryOrders_t -> Orders_t
  • pgr_global_report -> 'vrp_global_report`
    • & free the memory of the messages
  • alloc.*
    • adding: namespace vrprouting
    • pgr_fn -> fn
  • postgres_connection.*
    • pgr_SPI_fn -> vrp_SPI_fn
    • prepares the file to be included in C++
    • remove unused code
  • class Pgr_message -> class Message
  • (vroom.hpp) preparing separate on another PR the implementation from the header
    • reformatting to 4 spaces
  • f.c & f_driver.*
    • reformatting to 4 spaces
    • all drivers
    • only static process
    • removing doxy dic of static process
    • *.c removing useless comments (like the sql comment that is never mantained)
    • removing directive about PGSQL_VERSION > 95
  • sql/vroom
    • remove vrp_ from filenames

@pgRouting/admins

@cvvergara cvvergara added the enhancement New feature or request label Aug 6, 2024
@cvvergara cvvergara added this to the Release 0.4.2 milestone Aug 6, 2024
@cvvergara
Copy link
Member Author

Note that doxygen documentation is failing (because the update now catches things)
That I dont care much at this moment as there are more PR pending because of the code change to read the queries in C++.
Many fails are happening in code will be changed.

Copy link
Member

@sanak sanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !
(I will try macOS local build/test from around next PR. 😊)

@cvvergara cvvergara merged commit a1b7e67 into pgRouting:main Aug 8, 2024
6 of 8 checks passed
@cvvergara cvvergara deleted the many-small-tasks branch August 8, 2024 13:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Build enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants