Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Please document how to run the tests #323

Open
oliverklee opened this issue Jul 27, 2021 · 3 comments
Open

Please document how to run the tests #323

oliverklee opened this issue Jul 27, 2021 · 3 comments

Comments

@oliverklee
Copy link
Contributor

I'd like to contribute, but have trouble getting the unit tests to run (so that I can contribute in a test-driven way). The test setup is a bit unlike what I'm used to from other projects. I propose adding a .github/CONTRIBUTING.md file that explains the basics needed for contributing PRs. Thanks! <3

@theseer
Copy link
Member

theseer commented Jul 27, 2021

While indeed having a CONTRIBUTING.md is probably a good idea, I'm also a bit confused as to where the issue with running the tests would be?

phive install && ./tools/phpunit

Alternatively, ant -p should have gotten you started - which, as far as I at least was concerned - isn't very uncommon?

@oliverklee
Copy link
Contributor Author

Ah, I completely missed that PHIVE might also use PHIVE to install its tools. :-)

As far as Ant is concerned, this is the first PHP-based project which I've seen that uses Ant. So no, at least in my experience it's not so common. (I'm working mostly with Symfony and TYPO3.)

@theseer
Copy link
Member

theseer commented Jul 28, 2021

Funny, pretty much all my projects and as far as I know all of Sebastian Bergmann's use ANT. So at least in my little bubble, it's quite common ;-)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants