Skip to content

Commit 93b17da

Browse files
fix(betterer 🐛): add missing diff to summary when run is better (#959)
1 parent d147351 commit 93b17da

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

packages/betterer/src/run/worker-run.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -203,12 +203,13 @@ export class BettererWorkerRunΩ implements BettererRun {
203203
return end(BettererRunStatus.same, result);
204204
}
205205

206+
const diff = this.test.differ(this.expected.value, result.value);
206207
if (comparison === BettererConstraintResult.better) {
207-
return end(BettererRunStatus.better, result);
208+
return end(BettererRunStatus.better, result, diff);
208209
}
209210

210211
const status = config.update ? BettererRunStatus.update : BettererRunStatus.worse;
211-
return end(status, result, this.test.differ(this.expected.value, result.value));
212+
return end(status, result, diff);
212213
},
213214
failed: async (error: BettererError): Promise<BettererRunSummary> => {
214215
return end(BettererRunStatus.failed, null, null, error);

test/better-result.spec.ts

+3
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ module.exports = {
4343

4444
expect(testNames(secondRun.better)).toEqual(['should shrink', 'should grow']);
4545

46+
const [betterSummary] = secondRun.better;
47+
expect(betterSummary.diff).toBeDefined();
48+
4649
expect(logs).toMatchSnapshot();
4750

4851
const result = await readFile(resultsPath);

test/worse-result.spec.ts

+3
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ module.exports = {
4343

4444
expect(testNames(secondRun.worse)).toEqual(['should shrink', 'should grow']);
4545

46+
const [worseSummary] = secondRun.worse;
47+
expect(worseSummary.diff).toBeDefined();
48+
4649
expect(logs).toMatchSnapshot();
4750

4851
const result = await readFile(resultsPath);

0 commit comments

Comments
 (0)