Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Be able to print after install #130

Open
jxstxn1 opened this issue Dec 5, 2022 · 1 comment
Open

Be able to print after install #130

jxstxn1 opened this issue Dec 5, 2022 · 1 comment
Labels
plugins All plugin related issues

Comments

@jxstxn1
Copy link

jxstxn1 commented Dec 5, 2022

I want to be able to print something like the usage after a successful install.

@Giuspepe
Copy link
Contributor

Giuspepe commented Dec 5, 2022

Currently we are printing the following during installation of a plugin:

Installing my_plugin for my_cli
Installer downloaded
Preparing my_plugin installer...
Executing installer my_plugin...
Installed my_plugin for my_cli

Right now, plugin developers can only print something from their install.dart (so between Executing installer my_plugin... and Installed my_plugin for my_cli).

I see two ways to print something after the InstallPluginCommand prints 'Installed $pluginName for ${target.cliName}':

  1. The plugin developer could create a file with the after-installation message from his install.dart. Then in InstallPluginCommand we can check whether such a file exists and print its contents after printing 'Installed $pluginName for ${target.cliName}'.
  2. We move printing 'Installed $pluginName for ${target.cliName}' from InstallPluginCommand to the plugin's install.dart

However, would this effort be worth it? In the end it's just about printing Installed my_plugin for my_cli one line earlier or later 🤔

@passsy passsy added the plugins All plugin related issues label Jan 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
plugins All plugin related issues
Projects
None yet
Development

No branches or pull requests

3 participants