-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add CI tests if PR is installable with Symfony and Laravel #141
Comments
There is already something for this in travis from what I can see https://github.com/php-pm/php-pm-httpkernel/blob/master/.travis.yml#L20 Is this just a matter of adding in the script section in travis.yml? |
Noticed the need during php-pm/php-pm#431.
The tricky part is installing the current PR into the generated framework project. Only approach I could find was fiddling with local composer repositories (https://getcomposer.org/doc/05-repositories.md#path)? |
Leaving Travis aside, what are the steps to reproduce those issues from scratch?
Are these the correct steps to test? |
Actually now that I think of it, can't we just replace the line in travis.yml: This will widen the scope of the dependencies to what the actual frameworks install and should catch those conflicts. Edit: To be more correct we should split this line to install laravel, symfony and drupal separately, since each framework may install conflicting dependencies with each other. |
No description provided.
The text was updated successfully, but these errors were encountered: