Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Call to undefined method Prophecy\Argument::in() #522

Closed
tyteen4a03 opened this issue Mar 4, 2021 · 3 comments · Fixed by #523
Closed

Call to undefined method Prophecy\Argument::in() #522

tyteen4a03 opened this issue Mar 4, 2021 · 3 comments · Fixed by #523

Comments

@tyteen4a03
Copy link

Unlike other functions in Argument, in() and notIn() are not static methods, causing an error when trying to call it statically.

It should be changed to static to be in line with other methods.

@stof
Copy link
Member

stof commented Mar 4, 2021

this is indeed a mistake.

Can you send a PR doing the change ?

@tyteen4a03
Copy link
Author

@stof I have no problem doing a PR but I'm just wondering if this would constitute an API breaking change? (I can also keep both in and deprecate the non-static one.)

@ciaranmcnulty
Copy link
Member

We've only ever documented static calls and it's clearly an error so I'd count it as a bug fix

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants