From 1d4ab0a71071f9cbd97de75725a61bcd2d7fb318 Mon Sep 17 00:00:00 2001
From: Ondrej Mirtes <ondrej@mirtes.cz>
Date: Mon, 19 Jul 2021 15:02:54 +0200
Subject: [PATCH] EntityColumnRule - test Id without GeneratedValue

---
 .../Doctrine/ORM/EntityColumnRuleTest.php     |  7 +++++++
 .../Doctrine/ORM/data/GeneratedIdEntity5.php  | 20 +++++++++++++++++++
 .../Doctrine/ORM/data/GeneratedIdEntity6.php  | 20 +++++++++++++++++++
 3 files changed, 47 insertions(+)
 create mode 100644 tests/Rules/Doctrine/ORM/data/GeneratedIdEntity5.php
 create mode 100644 tests/Rules/Doctrine/ORM/data/GeneratedIdEntity6.php

diff --git a/tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php b/tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php
index 27710827..6720de1b 100644
--- a/tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php
+++ b/tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php
@@ -176,6 +176,13 @@ public function generatedIdsProvider(): Iterator
 		yield 'nullable property' => [__DIR__ . '/data/GeneratedIdEntity3.php', []];
 		yield 'nullable both' => [__DIR__ . '/data/GeneratedIdEntity4.php', []];
 		yield 'composite' => [__DIR__ . '/data/CompositePrimaryKeyEntity1.php', []];
+		yield 'no generated value 1' => [__DIR__ . '/data/GeneratedIdEntity5.php', []];
+		yield 'no generated value 2' => [__DIR__ . '/data/GeneratedIdEntity6.php', [
+			[
+				'Property PHPStan\Rules\Doctrine\ORM\GeneratedIdEntity6::$id type mapping mismatch: property can contain int|null but database expects int.',
+				18,
+			],
+		]];
 	}
 
 	public function testCustomType(): void
diff --git a/tests/Rules/Doctrine/ORM/data/GeneratedIdEntity5.php b/tests/Rules/Doctrine/ORM/data/GeneratedIdEntity5.php
new file mode 100644
index 00000000..5d078c01
--- /dev/null
+++ b/tests/Rules/Doctrine/ORM/data/GeneratedIdEntity5.php
@@ -0,0 +1,20 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Entity()
+ */
+class GeneratedIdEntity5
+{
+
+	/**
+	 * @ORM\Id()
+	 * @ORM\Column(type="integer", nullable=false)
+	 * @var int
+	 */
+	private $id;
+
+}
diff --git a/tests/Rules/Doctrine/ORM/data/GeneratedIdEntity6.php b/tests/Rules/Doctrine/ORM/data/GeneratedIdEntity6.php
new file mode 100644
index 00000000..24a4837d
--- /dev/null
+++ b/tests/Rules/Doctrine/ORM/data/GeneratedIdEntity6.php
@@ -0,0 +1,20 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Entity()
+ */
+class GeneratedIdEntity6
+{
+
+	/**
+	 * @ORM\Id()
+	 * @ORM\Column(type="integer", nullable=false)
+	 * @var int|null
+	 */
+	private $id;
+
+}