Internal error: Class Doctrine\ORM\EntityRepository does not exist

[josefsabl]

I'd like to open new issue here, but it was discussed after closing this issue: #51

Looks like this plugin depends on the doctrine/orm although it definitely is useful for doctrine/odm as also stated in readme (Also supports Doctrine ODM.).

The fact is that it really works well for ODM project and I could delete a few ignore patterns. But I had to add doctrine/orm to my composer.json to make it work. Which is a shame.

I think it would not harm if this package added doctrine/orm as one of its own dependencies.

[ondrejmirtes]

I think it would not harm if this package added doctrine/orm as one of its own dependencies.

It should not be solved like this, but instead asking if Doctrine ORM classes exist before using them.

[josefsabl]

Yeah, of course, that would be ideal :-)

[zacharra]

Hello,
is there any progress regarding this issue? In case it isn't obvious already, the issue is this line:

phpstan-doctrine/src/Reflection/Doctrine/EntityRepositoryClassReflectionExtension.php

Line 14 in 95ffd12

|| $classReflection->isSubclassOf('Doctrine\ORM\EntityRepository')

where isSubclassOf calls \ReflectionClass:isSubclassOf(), which expects the argument class to exist. It could be easily solved with a class_exists check before that, but I don't know if there is a better way, e.g. only conditionally load the extension or something.

[josefsabl]

In case it isn't obvious already, the issue is this line:

Unfortunatelly changing this line to:

|| (class_exists('Doctrine\ORM\EntityRepository') && $classReflection->isSubclassOf('Doctrine\ORM\EntityRepository'))

Generates tons of other false positive errors.

[ondrejmirtes]

@josefsabl I don't know what false positives do you mean.

Fixed: 98a7072

[josefsabl]

I don't know what false positives do you mean.

Please disregard that post of mine. I just wanted to test the proposed solution by @zacharra only to find that it isn't that simple.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.