Skip to content

The constant_hassers not working as constantHassers default of extension.neon always used #364

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
alexander-schranz opened this issue Oct 18, 2023 · 0 comments

Comments

@alexander-schranz
Copy link
Contributor

The extension is setting:

		constant_hassers: true
		constantHassers: true

in our libraries which we had phpstan update it still uses:

		constant_hassers: true

But this seems not has longer any effects based on the code here:

return $this->parameters['constantHassers'] ?? $this->parameters['constant_hassers'] ?? true;

I think constant_hassers never has any effects as constantHassers is still always true. So this BC Layer seems not to work maybe extension.neon should go with:

		constant_hassers: null
		constantHassers: null

What do you think?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant