Skip to content

Commit 961b0ef

Browse files
authored
fix(TSE-1157): Improve US datacenter documentation and typings (#47)
1 parent 8f5318a commit 961b0ef

File tree

5 files changed

+4792
-13846
lines changed

5 files changed

+4792
-13846
lines changed

.tool-versions

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
nodejs 18.16.1
1+
nodejs 20.0.0

README.md

+2-19
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,9 @@ initializePhraseAppEditor(config);
7676

7777
#### Using the US Datacenter with ICE
7878

79-
In addition to `phraseEnabled`, `projectId` and `accountID` in the config, also add the US specific URLs to enable working through the US endpoint.
79+
In addition to the settings in your config, set the US datacenter to enable it working with the US endpoints.
8080
```js
81-
baseUrl: "https://us.app.phrase.com",
82-
apiBaseUrl: 'https://api.us.app.phrase.com/api/v2',
83-
oauthEndpointUrl: "https://api.us.app.phrase.com/api/v2/authorizations",
84-
profileUrl: "https://us.app.phrase.com/settings/profile",
81+
datacenter: 'us'
8582
```
8683

8784
### Code examples
@@ -145,20 +142,6 @@ export function HttpLoaderFactory(http: HttpClient) {
145142

146143
If this does not work for you, you can also integrate the [JavaScript snippet manually](https://help.phrase.com/help/integrate-in-context-editor-into-any-web-framework).
147144

148-
149-
### Using the US Datacenter with ICE
150-
151-
In addition to `phraseEnabled` and `projectId` in the config, also add the US specific URLs to enable working through the US endpoint.
152-
```ts
153-
let config: PhraseConfig = {
154-
// ...
155-
baseUrl: "https://us.app.phrase.com",
156-
apiBaseUrl: 'https://api.us.app.phrase.com/api/v2',
157-
oauthEndpointUrl: "https://api.us.app.phrase.com/api/v2/authorizations",
158-
profileUrl: "https://us.app.phrase.com/settings/profile",
159-
}
160-
```
161-
162145
## :white_check_mark: Commits & Pull Requests
163146

164147
We welcome anyone who wants to contribute to our codebase, so if you notice something, feel free to open a Pull Request! However, we ask that you please use the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification for your commit messages and titles when opening a Pull Request.

0 commit comments

Comments
 (0)