TypeScript definition is not published

[lacolaco]

ngx-translate-phraseapp npm package doesn't contain its own TypeScript type definition.

[theSoenke]

Hi, I will look into adding the type definitions. Do you use any settings that enforce the usage of type definitions? For example our demo project works fine without the type definitions https://github.com/phrase/ngx-translate-phraseapp-demo

[lacolaco]

@theSoenke Simply, strict: true in tsconfig.app.json. It restricts many ambiguous typing including no-definition importing.

[theSoenke]

@lacolaco I just published version 0.1.6. This release now should contain the Typescript type definitions. Let me know if you should still see any issues

[lacolaco]

@theSoenke I've update version and it works perfectly! Thanks!

[mikyaj]

@theSoenke I am facing same issue with version 0.3.0

[theSoenke]

Hi @mikyaj, I was able to reproduce it myself and I'm looking into it

[FRSgit]

Hello @mikyaj! Could you please share your project's config (especially tsconfig.json)?
I want to make sure that your case is covered by the fix I've just written

[mikyaj]

Here you go @FRSgit

{
  "compileOnSave": false,
  "compilerOptions": {
    "baseUrl": "./",
    "downlevelIteration": true,
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "module": "esnext",
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "target": "es2015",
    "resolveJsonModule": true,
    "esModuleInterop": true  ,
    "typeRoots": [
      "node_modules/@types"
    ],
    "lib": [
      "es2018",
      "dom"
    ]
  }
}

[FRSgit]

Hey @mikyaj! I'm sorry that it took so long. I've just released new version of the package (0.4.1) and it should resolve the issue you're facing. Can you check it please? ✌️

[mikyaj]

Hi @FRSgit It works fine now. I hace checked. Thanks.

[FRSgit]

@mikyaj Thank you for testing my fix 💪 Glad to hear that it works now! Sorry that you needed to wait for so long - I needed to make few more adjustments to make this change possible.
Feel free to contact us whenever you need to, have a good one! 👌