Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace use of magic numbers in drivers with named constants #86

Open
phillipstanleymarbell opened this issue May 25, 2020 · 0 comments

Comments

@phillipstanleymarbell
Copy link
Member

For example, the values we use for setting the ctrl_meas register for the BME680

For example, the literal constant 0b00000001 in

numberOfConfigErrors += configureSensorBME680( 0b00000001, /* Humidity oversampling (OSRS) to 1x */
)

should be named constants (e.g., kWarpDevBME680HumidityOversampling1x or something better, to be defined in the corresponding driver header file).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant