path-to-regexp@^8.0.0

[wesleytodd]

Updates to path-to-regexp@8.

So from the tests, the three breaking changes are:

1. We drop support for partial capture group router.route('/user(s?)/:user/:op') but still have optional non-capture /user{s}/:user/:op
2. :name? becomes {:name}
3. :name* becomes *name.
4. The splat change also changes splat from strings to an array of strings
5. Optional splats become {*name}
6. :name+ becomes *name and thus equivalent to *name so I dropped those tests
7. Strings as regular expressions are fully removed, need to be converted to native regular expressions

I am going to link this into express and see locally if this set of breaking changes holds up in that test suite now.

[wesleytodd]

I am about to rebase this onto the new CI and lint changes. I should probably just life out the changes, but I like a challenge with git and what is the point of doing this if we are not having fun while we do it?

[wesleytodd]

ok I think I did this correctly. There was a duplicate test and a few things which made it confusing, but I think once we get path-to-regexp@8 released this is nearly ready.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/path-to-regexp@8.0.0	None	0	51.3 kB	blakeembrey

🚮 Removed packages: npm/path-to-regexp@3.2.0)

View full report↗︎

[wesleytodd]

I was trying to figure out how this one worked before, but I am thinking this might be a weird git diff thing from a rebase. The /bar route should not have "hit" it would have needed the line 2 below to flip if we kept this as zoo. Anyway, not a really meaningful change so I am not going to try and undo what ever I missed in the merge and just push forward.

[wesleytodd]

Looks like this change was because something was broken it just is not covered directly in these tests but is covered in the express tests. Will try and port over the correct test here.

[wesleytodd]

While looking at the express tests I think we might be able to bring this one back in a different form. The interesting part is that the optional group is no longer captured because we dropped support for unnamed params. @blakeembrey just want to confirm this is our expected behavior.

This is the test as written in express:

    it('should work following a partial capture group', function(done){
      var app = express();
      var cb = after(2, done);

      app.get('/user{s}/:user/:op', function(req, res){
        res.end(req.params.op + 'ing ' + req.params.user + (req.url.startsWith('/users') ? ' (old)' : ''));
      });

      request(app)
      .get('/user/tj/edit')
      .expect('editing tj', cb);

      request(app)
      .get('/users/tj/edit')
      .expect('editing tj (old)', cb);
    })

[blakeembrey]

This is correct, there's no regex or unnamed group features right now. I think we could bring this back given time but right now it isn't possible.