Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop support for node <18 #119

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Drop support for node <18 #119

merged 2 commits into from
Sep 1, 2024

Conversation

wesleytodd
Copy link
Member

No description provided.

@wesleytodd
Copy link
Member Author

I saw this test fail locally in some cases. Will look into it now that I also see it in CI. So many of these tests are failing locally but start working when I seralize the requests. I am nearly positive this is a superagent bug, I will pull over all the fixes I was doing in #117 using serial I guess.

Copy link

socket-security bot commented Sep 1, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/run-series@1.1.9 None 0 5.66 kB feross

🚮 Removed packages: npm/after@0.8.2)

View full report↗︎

@wesleytodd
Copy link
Member Author

Ah QUERY my old friend. I guess this never got fixed in node 21. I am going to exclude that test for node 21 for now, and since that is not an LTS we can just remove it when we drop support for node 21 I think.

@wesleytodd wesleytodd merged commit 04f8c3b into 2.0 Sep 1, 2024
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants