Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BC in phpredis 6.1.0 #170

Closed
hethehe opened this issue Oct 10, 2024 · 3 comments
Closed

BC in phpredis 6.1.0 #170

hethehe opened this issue Oct 10, 2024 · 3 comments

Comments

@hethehe
Copy link

hethehe commented Oct 10, 2024

There is a breaking change in phpredis, see phpredis/phpredis#2564

If your project uses symfony/cache < 6.4.12 with redis enabled, the entire project crash with:

Compile Error: Declaration of Symfony\Component\Cache\Traits\Redis6Proxy::hSet($key, $member, $value): Redis|int|false must be compatible with Redis::hSet(string $key, mixed ...$fields_and_vals): Redis|int|false

Not sure if this should be intercepted by pimcore/docker, but it is certainly worth mentioning if anyone is looking for it.

*edited: changed version from < 6.4.11 to < 6.4.12

@evanjamesjackson
Copy link

evanjamesjackson commented Oct 10, 2024

We addressed in our fork of https://github.com/pimcore/skeleton by updating the composer.json dependencies to ^6.4.11: TorqIT/pimcore-skeleton@83bf7e7

@alexz707
Copy link
Contributor

Thanks for the info, I have looked into it and have opened a ticket in the pimcore/pimcore repo.
Will provide a PR soon - should be fixed by then.

@evanjamesjackson: is there a reason why you just updated symfony/dotenv & runtime without explicitely adding symfony cache?

@alexz707
Copy link
Contributor

merged into pimcore/pimcore

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants